Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with partial Hiredis availability #3400

Merged
merged 7 commits into from
Oct 4, 2024

Conversation

vladvildanov
Copy link
Collaborator

@vladvildanov vladvildanov commented Oct 2, 2024

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Closes #3392

@vladvildanov vladvildanov added the bug Bug label Oct 2, 2024
@vladvildanov vladvildanov changed the base branch from master to 5.1 October 2, 2024 14:58
redis/utils.py Outdated Show resolved Hide resolved
@dmaier-redislabs
Copy link
Contributor

Hi Vlad, it seems that the Code linter test is failing because of an unused import.

Copy link
Contributor

@dmaier-redislabs dmaier-redislabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@dmaier-redislabs dmaier-redislabs merged commit aa22225 into 5.1 Oct 4, 2024
54 checks passed
@dmaier-redislabs dmaier-redislabs deleted the vv-hiredis-version-fix branch October 4, 2024 10:01
vladvildanov added a commit that referenced this pull request Oct 7, 2024
* Updated package version (#3389)

* Fix bug with Redis Set commands returns List instead of Set (#3399)

* Fix bug with Redis Set commands returns List instead of Set in RESP2

* Removed fixture, codestyle fixes

* Fixed tests for async

* Fixed asyncio cluster test cases

* Added Sets alignment for RESP2 and RESP3

* Updated doctests

* Fix bug with partial Hiredis availability (#3400)

* Fix bug with partial Hiredis availability

* Added yes flag

* Codestyl fixes

* Removed redundant check

* Removed redundant checks associated with pack command

* Updated condition to check the actual flag

* Removed unused import

* Fix bug with async pipeline and cluster fails with some commands (#3402)

* Fix bug with async pipeline fails with some commands

* Codestyl changes

* Remove keys option in cluster context

* Updated package version (#3403)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seeking guidance for hiredis dependency on redis-py
2 participants