Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct RESP3 return type Set for SDIFF, SINTER, SUNION, SMEMBERS, SPOP #2683

Closed
wants to merge 1 commit into from

Conversation

zuiderkwast
Copy link
Contributor

The return type of these commands is listed as array, but in RESP3 they return a set reply.

I suspect the reason for this originates from the fact that the reply schema is a JSON schema, and JSON doesn't have sets, so the schemas don't distinguish between arrays and sets.

@guybe7

Copy link

netlify bot commented Mar 11, 2024

👷 Deploy request for redis-doc pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 99ff502

@zuiderkwast zuiderkwast changed the title Correct RESP3 return type Set for SDIFF, SITER, SUNION, SMEMBERS, SPOP Correct RESP3 return type Set for SDIFF, SINTER, SUNION, SMEMBERS, SPOP Mar 11, 2024
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Yury-Fridlyand
Copy link

Voting for merging this:

$ redis-cli -3
127.0.0.1:6379> sinter s1
1~ "a"
127.0.0.1:6379> sinter s1
1~ "a"
127.0.0.1:6379> sinter s1 s2
(empty set)
127.0.0.1:6379> smembers s1
1~ "a"
127.0.0.1:6379>

@zuiderkwast zuiderkwast closed this Apr 3, 2024
@zuiderkwast zuiderkwast deleted the reply-set branch April 3, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants