fix: expand variables in Plugin._verify_all_device_commands #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to expand variables before calling the @command function. This is actually done for _execute_all[_non]_device_commands and _verify_all_non_device_commands, but not in _verify_all_device_commands. This adds the missing expansion. Signed-off-by: Adriaan Schmidt <adriaan.schmidt@siemens.com>
zacikpa
approved these changes
Sep 18, 2024
|
@yarda ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to expand variables before calling the
@commandfunction. This is actually done for_execute_all[_non]_device_commandsand_verify_all_non_device_commands, but not in_verify_all_device_commands.This adds the missing expansion.