Removing IBM suggested attribute rule #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 Navigate the preview: https://redhat-documentation-vale-at-red-hat-882.surge.sh 🎊 |
|
I agree. There are too many exceptions. |
apinnick
approved these changes
Sep 12, 2024
|
Change is OK to me. It's very difficult to test these things. I created this rule at the time as I had to crawl the openshift-docs repo to change all instance of IBM names. A rule was a way to flag bad habits of reverting going back to hardcoding IBM names and dropping the RT symbol. |
|
@dfitzmau all the other work you've done there is good though. Kudos. This one is just too generic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rule that flags "IBM" is too simple and prone to false positives. In general, if a Vale rule is producing false positives, it's not fit for purpose and just adds noise and friction.
"When in doubt, leave it out" 😺