Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating docs to recommend minimum version for using Vale with VRH #873

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

aireilly
Copy link
Member

@aireilly aireilly commented Aug 27, 2024

The Vale at Red Hat rules require Vale 3.7+ to be installed.

Copy link

github-actions bot commented Aug 27, 2024

🎊 Navigate the preview: https://redhat-documentation-vale-at-red-hat-873.surge.sh 🎊

@aireilly aireilly requested a review from rolfedh August 27, 2024 08:45
@aireilly aireilly merged commit 4b48941 into redhat-documentation:main Aug 27, 2024
3 checks passed
----
vale version 3.6.1
----

Copy link
Collaborator

@rolfedh rolfedh Aug 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good information! However, it may not align with the experience of Red Hat users who follow the installation instructions for Linux users at vale.sh, which use snap. In that case, users typically see:

[rdlugyhe@rdlugyhe-thinkpadt14sgen2i ~]$ which vale
/var/lib/snapd/snap/bin/vale
[rdlugyhe@rdlugyhe-thinkpadt14sgen2i ~]$ vale --version
vale version master

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The snap package manager automatically gets and runs the latest version of the package being run by the user.

Copy link
Member Author

@aireilly aireilly Aug 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snap is an additional package manager that is not installed by default in Fedora OS. Seems strange that the vale install does not report the version though. That is odd.

Also I just installed snap on F40, and got this error:

$ sudo snap install vale
error: too early for operation, device not yet seeded or device model not acknowledged

For RHEL and Fedora, see https://redhat-documentation.github.io/vale-at-red-hat/docs/main/user-guide/installing-vale-cli/

Copy link
Collaborator

@rolfedh rolfedh Aug 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got that on the first try immediately after installing snap. I reran the command and the issue cleared.

@aireilly aireilly mentioned this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants