Add bare-metal instance as valid #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 Navigate the preview: https://redhat-documentation-vale-at-red-hat-863.surge.sh 🎊 |
apinnick
force-pushed
the
bare-metal-instance
branch
from
fad27b4
to
335e8b1
Compare
apinnick
force-pushed
the
bare-metal-instance
branch
from
335e8b1
to
42ab56b
Compare
rolfedh
reviewed
Aug 26, 2024
| @@ -19,8 +19,8 @@ swap: | |||
| "(?<!Mozilla )Thunderbird": Mozilla Thunderbird | |||
| "(?<!pseudo-)ops": operations | |||
| "(?<!self-)hosted engine|hosted-engine": self-hosted engine | |||
| "bare metal( clusters?| compute| configuration| controls?| environments?| equipment| events?| hardware| hosts?| infrastructure| installations?| installers?| machines?| media| nodes?| provisioning| servers?| workers?)": bare-metal$1 | |||
| "bare-metal(?! clusters?| compute| configuration| controls?| environments?| equipment| events?| hardware| hosts?| infrastructure| installations?| installers?| machines?| media| nodes?| provisioning| servers?| workers?)": bare metal | |||
| "bare metal( clusters?| compute| configuration| controls?| environments?| equipment| events?| hardware| hosts?| infrastructure| installations?| installers?| instance?| machines?| media| nodes?| provisioning| servers?| workers?)": bare-metal$1 | |||
There was a problem hiding this comment.
Suggested change
| "bare metal( clusters?| compute| configuration| controls?| environments?| equipment| events?| hardware| hosts?| infrastructure| installations?| installers?| instance?| machines?| media| nodes?| provisioning| servers?| workers?)": bare-metal$1 | |
| "bare metal( clusters?| compute| configuration| controls?| environments?| equipment| events?| hardware| hosts?| infrastructure| installations?| installers?| instances?| machines?| media| nodes?| provisioning| servers?| workers?)": bare-metal$1 |
| "bare metal( clusters?| compute| configuration| controls?| environments?| equipment| events?| hardware| hosts?| infrastructure| installations?| installers?| machines?| media| nodes?| provisioning| servers?| workers?)": bare-metal$1 | ||
| "bare-metal(?! clusters?| compute| configuration| controls?| environments?| equipment| events?| hardware| hosts?| infrastructure| installations?| installers?| machines?| media| nodes?| provisioning| servers?| workers?)": bare metal | ||
| "bare metal( clusters?| compute| configuration| controls?| environments?| equipment| events?| hardware| hosts?| infrastructure| installations?| installers?| instance?| machines?| media| nodes?| provisioning| servers?| workers?)": bare-metal$1 | ||
| "bare-metal(?! clusters?| compute| configuration| controls?| environments?| equipment| events?| hardware| hosts?| infrastructure| installations?| installers?| instance?| machines?| media| nodes?| provisioning| servers?| workers?)": bare metal |
There was a problem hiding this comment.
Suggested change
| "bare-metal(?! clusters?| compute| configuration| controls?| environments?| equipment| events?| hardware| hosts?| infrastructure| installations?| installers?| instance?| machines?| media| nodes?| provisioning| servers?| workers?)": bare metal | |
| "bare-metal(?! clusters?| compute| configuration| controls?| environments?| equipment| events?| hardware| hosts?| infrastructure| installations?| installers?| instances?| machines?| media| nodes?| provisioning| servers?| workers?)": bare metal |
There was a problem hiding this comment.
Hi @apinnick,
While researching a Vale issue I came across this recent PR you contributed.
It looks like the ? symbol is used to make the plural s at the end of these strings optional. I've added "s" to "instance" strings in the PR I created to fix the aforementioned issue: #872.
Thanks!
There was a problem hiding this comment.
Aha. OK, now I get it. Your explanation makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "bare-metal instance" to valid list