-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating a new localization rule set for vale #788
base: main
Are you sure you want to change the base?
Changes from all commits
dff40b8
9285481
1d89638
0df7fc7
20dd43a
847522c
2e89ff3
75c8180
f3ac5ff
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
; Vale configuration file to test the `AdjectivesWithNouns` rule | ||
StylesPath = ../../../styles | ||
MinAlertLevel = warning | ||
[*.adoc] | ||
Localization.TermsWarnings = YES |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
the following | ||
the previous |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
the following steps | ||
the following functions | ||
the following procedure | ||
the following chapter | ||
the following table | ||
the following image | ||
the following section | ||
the previous steps | ||
the previous functions | ||
the previous procedure | ||
the previous chapter | ||
the previous table | ||
the previous image | ||
the previous section | ||
this function is | ||
those instructions are |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
; Vale configuration file to test the `CommonlyMisusedWords` rule | ||
StylesPath = ../../../styles | ||
MinAlertLevel = warning | ||
[*.adoc] | ||
Localization.TermsWarnings = YES |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
The product allows you to | ||
This product allows you to | ||
The product allows | ||
This product allows | ||
The interface allows | ||
The UI allows | ||
The application allows | ||
This feature allows you to | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
might | ||
enable | ||
abbreviation | ||
can | ||
cannot | ||
Red Hat allows you to | ||
Red Hat allows | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
; Vale configuration file to test the `Modals` rule | ||
StylesPath = ../../../styles | ||
MinAlertLevel = warning | ||
[*.adoc] | ||
Localization.TermsWarnings = YES |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
should | ||
could | ||
would | ||
will | ||
supposed to | ||
ought to be | ||
may | ||
shall |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
might | ||
can | ||
cannot | ||
must | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
; Vale configuration file to test the `PhrasalVerbs` rule | ||
StylesPath = ../../../styles | ||
MinAlertLevel = warning | ||
[*.adoc] | ||
Localization.TermsWarnings = YES | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
carry out | ||
allow for | ||
carry on | ||
count on | ||
end up | ||
get at | ||
click on | ||
call up | ||
find out | ||
print out | ||
start up | ||
switch on | ||
tap on | ||
fill in | ||
fill out | ||
picks up | ||
gives up |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
do | ||
allow | ||
enable | ||
continue | ||
depend | ||
result | ||
imply | ||
click |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,5 @@ | ||||||
; Vale configuration file to test the `WordswithMultipleMeanings` rule | ||||||
StylesPath = ../../../styles | ||||||
MinAlertLevel = warning | ||||||
[*.adoc] | ||||||
Localization.TermsWarnings = YES | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
as | ||
at once | ||
once | ||
while | ||
since |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
after | ||
reachlekha marked this conversation as resolved.
Show resolved
Hide resolved
|
||
one time | ||
because | ||
during | ||
at the same time | ||
as soon as | ||
as much as | ||
as long as | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
--- | ||
extends: sequence | ||
message: "Do not use adjectives without a noun following them. For example, use 'Complete the following steps' instead of 'Complete the following'." | ||
link: https://redhat-documentation.github.io/vale-at-red-hat/docs/main/reference-guide/using/ | ||
level: warning | ||
action: | ||
name: edit | ||
tokens: | ||
- the following | ||
- the previous | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
--- | ||
extends: existence | ||
ignorecase: true | ||
level: suggestion | ||
link: https://redhat-documentation.github.io/vale-at-red-hat/docs/main/reference-guide/termswarnings/ | ||
message: 'Only use allow if you are talking about permission. For ability, use enable.' | ||
# source: https://github.com/redhat-documentation/vale-at-red-hat/issues/515 | ||
tokens: | ||
- The product allows you to | ||
- This product allows you to | ||
- The product allows | ||
- This product allows | ||
- The interface allows | ||
- The UI allows | ||
- The application allows | ||
- This feature allows you to | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
--- | ||
extends: existence | ||
ignorecase: true | ||
level: warning | ||
link: https://redhat-documentation.github.io/vale-at-red-hat/docs/main/reference-guide/termswarnings/ | ||
message: "Avoid using modals like 'should', 'may', or 'will' because they can introduce uncertainty." | ||
# source: https://github.com/redhat-documentation/vale-at-red-hat/issues/515 | ||
tokens: | ||
- should | ||
- could | ||
- would | ||
- will | ||
- supposed to be | ||
- ought to be | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
--- | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. General comment for this rule - as it is laid out below, there will be a huge amount of false positives for this rule. Need to reduce the false positives to make this useful. |
||
extends: substitution | ||
reachlekha marked this conversation as resolved.
Show resolved
Hide resolved
|
||
ignorecase: true | ||
level: warning | ||
link: https://redhat-documentation.github.io/vale-at-red-hat/docs/main/reference-guide/termswarnings/ | ||
message: "Avoid using phrasal verbs. Consider using '%s' rather than '%s'." | ||
scope: sentence | ||
action: | ||
name: replace | ||
swap: | ||
# Start each error message with "Do not use ..." | ||
# Error messages must be single quoted. | ||
Comment on lines
+11
to
+12
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't get this comment. It seems related to the error message,not the swap section There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @aireilly Could you please help clarify this rule? |
||
carry out: do | ||
allow for: allow|enable | ||
carry on: continue | ||
count on: depend | ||
end up: result | ||
get at: imply | ||
click on: click | ||
find out: find | ||
print out: print | ||
start up | switch on: start | ||
tap on: tap | ||
picks up: takes | ||
fill in: complete |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
--- | ||
extends: existence | ||
ignorecase: true | ||
level: warning | ||
link: https://redhat-documentation.github.io/vale-at-red-hat/docs/main/reference-guide/termswarnings/ | ||
message: "Avoid words that have multiple meanings. For example, instead of words like "as" or "since" which have multiple meanings, use "because"." | ||
# source: https://github.com/redhat-documentation/vale-at-red-hat/issues/515 | ||
tokens: | ||
- as | ||
- at once | ||
- once | ||
- while | ||
- since | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.