Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not report 'as well as per something' #606

Merged

Conversation

jhradilek
Copy link
Contributor

The current implementation of RedHat.TermsErrors causes vale to report the following error for sentences like "you can configure meta options per alert agent as well as per recipient":

 15:56   error       Use 'according to', 'as', or    RedHat.TermsErrors      
                     'as in' rather than 'as per'.

While "as well as" on its own is not recommended by the IBM Style Guide and gets reported by RedHat.Usage, the above error is out of place and the suggested wording is confusing.

@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

github-actions bot commented Aug 14, 2023

🎊 Navigate the preview: https://redhat-documentation-vale-at-red-hat-606.surge.sh 🎊

Copy link
Member

@aireilly aireilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aireilly aireilly merged commit 529e5b3 into redhat-documentation:main Aug 16, 2023
4 checks passed
@jhradilek jhradilek deleted the termserrors-as-well-as-per branch August 16, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants