Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHSTOR-6195: Bucket - list page #1598

Merged

Conversation

GowthamShanmugam
Copy link
Contributor

@GowthamShanmugam GowthamShanmugam commented Sep 26, 2024

https://issues.redhat.com/browse/RHSTOR-6195
ToDo bucket sync button after merging: #1591

To solve the bundle analyzer issue: #1626

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid jira ticket of any type label Sep 26, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 26, 2024

@GowthamShanmugam: This pull request references RHSTOR-6195 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 26, 2024

@GowthamShanmugam: This pull request references RHSTOR-6195 which is a valid jira issue.

In response to this:

https://issues.redhat.com/browse/RHSTOR-6195

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 26, 2024

@GowthamShanmugam: This pull request references RHSTOR-6195 which is a valid jira issue.

In response to this:

https://issues.redhat.com/browse/RHSTOR-6195
ToDo bucket sync button after merging: #1591

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@SanjalKatiyar
Copy link
Collaborator

SanjalKatiyar commented Sep 30, 2024

no need for extra "bucket" directory here: /s3-browser/bucket/buckets-list-page/bucketsListPage.tsx...
we can directly do packages/odf/components/s3-browser/buckets-list-page/bucketsListPage.tsx

Also, bucketsListPage.tsx should be BucketsListPage.tsx...

IIRC that's what we decided, cc @alfonsomthd to keep me honest.

@GowthamShanmugam
Copy link
Contributor Author

Screenshot 2024-10-03 at 9 25 38 PM

package.json Outdated Show resolved Hide resolved
@GowthamShanmugam GowthamShanmugam force-pushed the RHSTOR-6195 branch 3 times, most recently from 461d8c8 to f6d2a59 Compare October 8, 2024 11:10
@GowthamShanmugam
Copy link
Contributor Author

Screenshot 2024-10-08 at 4 31 00 PM

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 8, 2024

@GowthamShanmugam: This pull request references RHSTOR-6195 which is a valid jira issue.

In response to this:

https://issues.redhat.com/browse/RHSTOR-6195
ToDo bucket sync button after merging: #1591

To solve the bundle analyzer issue: #1626

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@GowthamShanmugam GowthamShanmugam force-pushed the RHSTOR-6195 branch 2 times, most recently from 89a6b13 to 335322d Compare October 8, 2024 12:59
@GowthamShanmugam
Copy link
Contributor Author

/test odf-console-e2e-aws

Signed-off-by: Gowtham Shanmugasundaram <gshanmug@redhat.com>
@SanjalKatiyar
Copy link
Collaborator

/lgtm

Copy link
Contributor

openshift-ci bot commented Oct 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GowthamShanmugam, SanjalKatiyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [GowthamShanmugam,SanjalKatiyar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 2ba9581 into red-hat-storage:master Oct 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved jira/valid-reference Indicates that this PR references a valid jira ticket of any type lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants