external: Defer secret hash update until all resources are successfully created #2904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @iamniting @travisn |
parth-gr
force-pushed
the
fix-external-reconcile
branch
from
142ee1a
to
5504d93
Compare
parth-gr
changed the title
|
Testing: |
iamniting
requested changes
Nov 22, 2024
There was a problem hiding this comment.
Changes looks good to me, though we need to work on a commit msg.
Defer secret hash update until all resources are successfully created
This update ensures that the secret hash in the storage cluster status is updated only after all resources are created successfully.
Previously, the status was updated prematurely, preventing the reconcile loop from re-running whether there was a failure or success. This change enables the reconcile process to continue retrying until all resources are successfully created.
malayparida2000
requested changes
Nov 22, 2024
parth-gr
force-pushed
the
fix-external-reconcile
branch
from
5504d93
to
c23c7e2
Compare
parth-gr
force-pushed
the
fix-external-reconcile
branch
2 times, most recently
from
dbbeb04
to
a9a1a2f
Compare
parth-gr
changed the title
parth-gr
force-pushed
the
fix-external-reconcile
branch
2 times, most recently
from
f8e21fd
to
bd21d8b
Compare
This update ensures that the secret hash in the storage cluster status is updated only after all resources are created successfully. Previously, the status was updated prematurely, preventing the reconcile loop from re-running whether there was a failure or success. This change enables the reconcile process to continue retrying until all resources are successfully created. Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr
force-pushed
the
fix-external-reconcile
branch
from
bd21d8b
to
45e4b7b
Compare
iamniting
approved these changes
Nov 22, 2024
openshift-ci
bot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting, malayparida2000, parth-gr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 3ef212d
into
red-hat-storage:main
11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update ensures that the secret hash in the storage cluster status is updated only after all resources are created successfully.
Previously, the status was updated prematurely, preventing the reconcile loop from re-running whether there was a failure or success. This change enables the reconcile process to continue retrying until all resources are successfully created.