-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix metrics params for k8s service monitor #2823
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Kaustav Majumder <kaustav.majumder@ibm.com>
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ezio-auditore The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Kaustav Majumder <kaustav.majumder@ibm.com>
/test all |
/test ocs-operator-bundle-e2e-aws |
/assign @umangachapagain |
/assign @aruniiird |
@ezio-auditore: GitHub didn't allow me to assign the following users: aruniiird. Note that only red-hat-storage members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Currently the params are generated in k8sservice monitor to federate in-cluster kube metrics as below which is wrong. This patch fixes the correct string params.
Also fixed tech debt to fetch kube-rbac-proxy image from environment variables