Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metrics params for k8s service monitor #2823

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ezio-auditore
Copy link
Contributor

@ezio-auditore ezio-auditore commented Sep 27, 2024

Currently the params are generated in k8sservice monitor to federate in-cluster kube metrics as below which is wrong. This patch fixes the correct string params.

params:
      match[]:
      - '{__name__=''kube_node_status_condition''}'
      - '{__name__=''kube_persistentvolume_info''}'
      - '{__name__=''kube_storageclass_info''}'
      - '{__name__=''kube_persistentvolumeclaim_info''}'
      - '{__name__=''kube_deployment_spec_replicas''}'
      - '{__name__=''kube_pod_status_phase''}'
      - '{__name__=''kubelet_volume_stats_capacity_bytes''}'
      - '{__name__=''kubelet_volume_stats_used_bytes''}'
      - '{__name__=''node_disk_read_time_seconds_total''}'
      - '{__name__=''node_disk_write_time_seconds_total''}'
      - '{__name__=''node_disk_reads_completed_total''}'
      - '{__name__=''node_disk_writes_completed_total''}'

Also fixed tech debt to fetch kube-rbac-proxy image from environment variables

Signed-off-by: Kaustav Majumder <kaustav.majumder@ibm.com>
Copy link
Contributor

openshift-ci bot commented Sep 27, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 27, 2024
Copy link
Contributor

openshift-ci bot commented Sep 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ezio-auditore
Once this PR has been reviewed and has the lgtm label, please assign travisn for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Kaustav Majumder <kaustav.majumder@ibm.com>
@ezio-auditore
Copy link
Contributor Author

/test all

@ezio-auditore ezio-auditore marked this pull request as ready for review October 14, 2024 10:32
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 14, 2024
@ezio-auditore
Copy link
Contributor Author

/test ocs-operator-bundle-e2e-aws

@ezio-auditore
Copy link
Contributor Author

/assign @umangachapagain

@ezio-auditore
Copy link
Contributor Author

/assign @aruniiird

Copy link
Contributor

openshift-ci bot commented Nov 4, 2024

@ezio-auditore: GitHub didn't allow me to assign the following users: aruniiird.

Note that only red-hat-storage members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @aruniiird

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants