Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test data science pipeline deletion #843

Merged
merged 5 commits into from
Jul 5, 2023
Merged

Test data science pipeline deletion #843

merged 5 commits into from
Jul 5, 2023

Conversation

diegolovison
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
338 0 0 338 100

@diegolovison
Copy link
Contributor Author

rhods-ci-pr-test/1907/

@bdattoma
Copy link
Contributor

bdattoma commented Jul 4, 2023

please could you replace ODS-2207 tag with ODS-2226? The first one assumes you delete objects from DS Project UI, instead this code uses Pipelines page

@jgarciao jgarciao changed the title Delete Pipeline Test data science pipeline deletion Jul 4, 2023
@jgarciao jgarciao self-requested a review July 4, 2023 18:53
jgarciao
jgarciao previously approved these changes Jul 4, 2023
View reviewed changes
@jgarciao jgarciao requested a review from bdattoma July 4, 2023 18:55
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 5, 2023
View reviewed changes
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataSciencePipelines.resource
... "Data Science Pipelines" -> Runs. In the new page, select the tab "Triggered".
... The "Delete Pipeline Run" will search for a line in the grid that match the pipeline name and
... the run name. Based on that, hit the ... Menu in the row and hit Delete drop down menu.
[Arguments] ${run_name} ${pipeline_name}

Check warning

Code scanning / Robocop

Keyword argument '{{ name }}' is not used

Keyword argument '${pipeline_name}' is not used
@sonarcloud
Copy link

sonarcloud bot commented Jul 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bdattoma bdattoma requested a review from jgarciao July 5, 2023 14:16
@bdattoma bdattoma added the new test New test(s) added (PR will be listed in release-notes) label Jul 5, 2023
@diegolovison diegolovison merged commit 20731b6 into red-hat-data-services:master Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdattoma bdattoma bdattoma approved these changes

@jgarciao jgarciao jgarciao approved these changes

Assignees

@diegolovison diegolovison

Labels
new test New test(s) added (PR will be listed in release-notes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diegolovison @bdattoma @jgarciao