Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added TrustyAI components + default payloadProcessor value for MM configuration #315

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

RobGeada
Copy link

@RobGeada RobGeada commented Mar 6, 2023

This PR adds the deployment specifications for the TrustyAI service, as well as a blank default value within the config-defaults of modelmesh. This lets the ModelMesh config map to be updated later, which lets TrustyAI be installed into an existing RHODS cluster.

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • For commits that came from upstream, [UPSTREAM] has been prepended to the commit message
  • JIRA link(s):
  • The Jira story is acked
  • An entry has been added to the latest build document in Build Announcements Folder.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious)

Testing instructions:

  1. Install the ODH operator into your cluster
  2. git clone https://github.com/red-hat-data-services/trustyai-explainability
  3. Run the E2E test from the the TrustyAI downstream repo: ./odh-deployment-e2e.sh robgeada TrustyAIInclusion

@RobGeada
Copy link
Author

@zdtsw
Copy link

zdtsw commented Jun 25, 2023

is this for upstream opendatahub-io#740 ?
should have upstream info and jira ticket added into PR's description

@RobGeada

@zdtsw
Copy link

zdtsw commented Jun 25, 2023

should https://github.com/red-hat-data-services/odh-manifests#components be updated to include trustyai ?

@zdtsw
Copy link

zdtsw commented Jan 29, 2024

should we close this @RobGeada ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants