Reason V4 Feature [Allow multiple versions of Resaon]

Summary:This allows multiple versions of Reason in a single project by
inferring and recording the version of syntax used into the file in an
attribute. The attribute allows us to switch the parser and lexer on the
fly. This attribute is not the only way we can infer the version, and we
can allow project level configuration, but this is the approach that is
guaranteed to work with any build system or tooling.

Test Plan:

Reviewers:

CC:

.ci/build-platform.yml

@@ -16,10 +16,10 @@ jobs:
       # Needed so that the mingw tar doesn't shadow the system tar. See
       # pipelines.yaml. We need windows bsdtar from system32, not the mingw
       # one. Note powershell doesn't need escaping of backslashes.
-      - powershell: Write-Host "##vso[task.setvariable variable=PATH;]C:\Windows\system32;${env:PATH}"
+      - powershell: Write-Host "##vso[task.setvariable variable=PATH;]C:\Program Files\Git\bin;C:\Windows\system32;${env:PATH}"
         continueOnError: true
         condition: eq(variables['AGENT.OS'], 'Windows_NT')
-        displayName: "Make sure windows/system32 is at front of path if windows"
+        displayName: "Make sure git/bin and windows/system32 is at front of path if windows"
       - powershell: $Env:Path
         continueOnError: true
         condition: and(eq(variables['AGENT.OS'], 'Windows_NT'), and(eq(variables['Build.Reason'], 'PullRequest'), and(succeeded(), ne(variables['Build.SourceBranch'], variables['System.PullRequest.TargetBranch']))))

docs/RELEASING.md

@@ -16,14 +16,32 @@ and `rtop.json` respectively in the repo root, you would run that script after
 committing/bumping some versions:
 
 
+**IMPORTANT: Update The Version Numbers In Packages:**
+1. Make sure the version number in `esy.json` and `reason.json` is the new
+   version number for the release.
+2. Make sure the file
+   [../../src/reason-version/reason_version.ml](../../src/reason-version/reason_version.ml)
+   also has that same version number that `refmt` has:
+
 ```sh
 git checkout -b MYRELEASE origin/master
 git rebase origin/master
-vim -O esy.json reason.json
-# Then edit the version number accordingly on BOTH files. With that same VERSION do:
-version=3.5.0 make pre_release
+vim -O esy.json reason.json src/reason-version/reason_version.ml
+
+# Edit version field in jsons, and make sure reason_version has the new version
+# let package_version = {
+#   major = 3;
+#   minor = 7;
+#   patch = 0;
+# }
+
 git commit -m "Bump version"
 git push origin HEAD:PullRequestForVersion # Commit these version bumps
+
+```
+
+**Perform The Release:**
+```sh
 node ./scripts/esy-prepublish.js ./reason.json ./rtop.json
 
 # Then publish. For example:

formatTest/typeCheckedTests/expected_output/arityConversion.re

@@ -1,3 +1,4 @@
+[@reason.version 3.7];
 Some((1, 2, 3));
 
 type bcd =

formatTest/typeCheckedTests/expected_output/attributes.4.04.0.re

@@ -1,3 +1,4 @@
+[@reason.version 3.7];
 /* Pexp_letexception with attributes */
 let () = {
   [@attribute]

formatTest/typeCheckedTests/expected_output/attributes.re

@@ -7,6 +7,7 @@
  * This has a nice side effect when printing the terms:
  * If a node has attributes attached to it,
  */;
+[@reason.version 3.7];
 
 /**Floating comment text should be removed*/;
 

formatTest/typeCheckedTests/expected_output/attributes.rei

@@ -1,6 +1,8 @@
 /* Copyright (c) 2015-present, Facebook, Inc. All rights reserved. */
 
 /**Floating comment text should be removed*/;
+[@reason.version 3.7];
+
 let test: int;
 
 /**

formatTest/typeCheckedTests/expected_output/basics.re

@@ -1,3 +1,4 @@
+[@reason.version 3.7];
 /* Copyright (c) 2015-present, Facebook, Inc. All rights reserved. */
 
 let l =

formatTest/typeCheckedTests/expected_output/basics_no_semi.re

@@ -1,3 +1,4 @@
+[@reason.version 3.7];
 /* Copyright (c) 2015-present, Facebook, Inc. All rights reserved. */
 
 let l =

formatTest/typeCheckedTests/expected_output/bigarraySyntax.re

@@ -1,3 +1,4 @@
+[@reason.version 3.7];
 /* https://github.com/facebook/reason/issues/2038 */
 let my_big_array1 =
   Bigarray.Array1.create(

formatTest/typeCheckedTests/expected_output/comments.re

@@ -1,6 +1,8 @@
 /* **** comment */
 /*** comment */
 /** docstring */;
+[@reason.version 3.7];
+
 /* comment */
 /** docstring */;
 /*** comment */

formatTest/typeCheckedTests/expected_output/comments.rei

@@ -8,6 +8,8 @@
 /***** comment */
 
 /** */;
+[@reason.version 3.7];
+
 /*** */
 /**** */
 

formatTest/typeCheckedTests/expected_output/comments.rei.4.07.0

@@ -1,6 +1,8 @@
 /* **** comment */
 /*** comment */
 /** docstring */;
+[@reason.version 3.7];
+
 /* comment */
 /** docstring */;
 /*** comment */

formatTest/typeCheckedTests/expected_output/comments.rei.4.07.1

@@ -1,6 +1,8 @@
 /* **** comment */
 /*** comment */
 /** docstring */;
+[@reason.version 3.7];
+
 /* comment */
 /** docstring */;
 /*** comment */

formatTest/typeCheckedTests/expected_output/comments.rei.4.08.0

@@ -1,6 +1,8 @@
 /* **** comment */
 /*** comment */
 /** docstring */;
+[@reason.version 3.7];
+
 /* comment */
 /** docstring */;
 /*** comment */

formatTest/typeCheckedTests/expected_output/comments.rei.4.09.0

@@ -1,6 +1,8 @@
 /* **** comment */
 /*** comment */
 /** docstring */;
+[@reason.version 3.7];
+
 /* comment */
 /** docstring */;
 /*** comment */

formatTest/typeCheckedTests/expected_output/features406.4.06.0.re

@@ -1,3 +1,4 @@
+[@reason.version 3.7];
 module EM = {
   /** Exception */
 

formatTest/typeCheckedTests/expected_output/features408.4.08.0.re

@@ -1,3 +1,4 @@
+[@reason.version 3.7];
 open {
        type t = string;
      };

formatTest/typeCheckedTests/expected_output/features408.4.08.0.rei

@@ -1,3 +1,4 @@
+[@reason.version 3.7];
 module X: {type t;};
 
 module M := X;

formatTest/typeCheckedTests/expected_output/imperative.re

@@ -1,3 +1,4 @@
+[@reason.version 3.7];
 /* Copyright (c) 2015-present, Facebook, Inc. All rights reserved. */
 
 /*

formatTest/typeCheckedTests/expected_output/jsx.re

@@ -1,3 +1,4 @@
+[@reason.version 3.7];
 type component = {displayName: string};
 
 module Bar = {

formatTest/typeCheckedTests/expected_output/knownMlIssues.re

@@ -1,3 +1,4 @@
+[@reason.version 3.7];
 /* [x] fixed */
 type t2 = (int, int); /* attributed to entire type not binding */
 

formatTest/typeCheckedTests/expected_output/knownReIssues.re

@@ -1,3 +1,4 @@
+[@reason.version 3.7];
 /**
    Issue 940: https://github.com/facebook/reason/issues/940
    The parens in the exception match case with an alias,

formatTest/typeCheckedTests/expected_output/lazy.re

@@ -1,3 +1,4 @@
+[@reason.version 3.7];
 let myComputation =
   lazy({
     let tmp = 10;

formatTest/typeCheckedTests/expected_output/letop.re

@@ -1,3 +1,4 @@
+[@reason.version 3.7];
 let (let.opt) = (x, f) =>
   switch (x) {
   | None => None

formatTest/typeCheckedTests/expected_output/mlSyntax.re

@@ -3,6 +3,7 @@
 /**
  * Testing pattern matching using ml syntax to exercise nesting of cases.
  */;
+[@reason.version 3.7];
 
 type xyz =
   | X

formatTest/typeCheckedTests/expected_output/mlVariants.re

@@ -1,3 +1,4 @@
+[@reason.version 3.7];
 /* Copyright (c) 2015-present, Facebook, Inc. All rights reserved. */
 
 type polyVariantsInMl = [

formatTest/typeCheckedTests/expected_output/mlVariants.re.4.06.1

@@ -1,3 +1,4 @@
+[@reason.version 3.7];
 /* Copyright (c) 2015-present, Facebook, Inc. All rights reserved. */
 
 type polyVariantsInMl = [

formatTest/typeCheckedTests/expected_output/mlVariants.re.4.07.1

@@ -1,3 +1,4 @@
+[@reason.version 3.7];
 /* Copyright (c) 2015-present, Facebook, Inc. All rights reserved. */
 
 type polyVariantsInMl = [

formatTest/typeCheckedTests/expected_output/mlVariants.re.4.08.0

@@ -1,3 +1,4 @@
+[@reason.version 3.7];
 /* Copyright (c) 2015-present, Facebook, Inc. All rights reserved. */
 
 type polyVariantsInMl = [

formatTest/typeCheckedTests/expected_output/mlVariants.re.4.09.0

@@ -1,3 +1,4 @@
+[@reason.version 3.7];
 /* Copyright (c) 2015-present, Facebook, Inc. All rights reserved. */
 
 type polyVariantsInMl = [

formatTest/typeCheckedTests/expected_output/mutation.re

@@ -1,3 +1,4 @@
+[@reason.version 3.7];
 /* Copyright (c) 2015-present, Facebook, Inc. All rights reserved. */
 
 /**

formatTest/typeCheckedTests/expected_output/newAST.4.06.0.re

@@ -1,3 +1,4 @@
+[@reason.version 3.7];
 /* Oinherit (https://github.com/ocaml/ocaml/pull/1118) */
 type t = {. a: string};
 

formatTest/typeCheckedTests/expected_output/oo.re

@@ -1,3 +1,4 @@
+[@reason.version 3.7];
 /* Copyright (c) 2015-present, Facebook, Inc. All rights reserved. */
 
 class virtual stack ('a) (init) = {