-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to jbuilder #30
base: RudiPlayground
Are you sure you want to change the base?
Port to jbuilder #30
Conversation
Wow thanks for providing an example so I can get a sense for how to use jBuilder. I don't have a lot of experience setting up native opam projects, so this is helpful to see.
In addition, I think what people would really want to see in a follow up diff:
I can create a playground branch if you want to push your work to it. We probably wouldn't want to encourage using jBuilder until it stabilizes, but a playground branch would be an easy way for you to try things out while jBuilder stabilizes. |
Sounds reasonable. |
* Using external dep * Internal library * Library for opam export * Binary
The pin is no longer necessary! Might want to update and we can start pointing people to this PR so they can test it out and get some feedback. Thanks again, @rgrinberg ! |
@rgrinberg It would also be really great if we could use this as an opportunity to teach people how to use opam effectively for local projects. For example, would you be able to suggest a workflow to teach newcomers:
I notice people mess these steps up frequently - especially when they have existing packages already installed in the global switch, which conflict. |
Bug report: When I clone down this PR and run
It seems it is overlooking the |
@gilbert Which version of jbuilder are you using? I hear the latest does not require you to pin that git URL - you merely need to install beta v9. |
@jordwalke I thought I was using the latest, but it turns out I wasn't. Using |
Hopefully this gets merged soon! |
This PR requires a minimum version of jbuilder: 1.0+beta9. This is the first version when reason was introduced.