Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update attribute admin #1194

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Update attribute admin #1194

merged 1 commit into from
Nov 19, 2024

Conversation

jochenklar
Copy link
Member

This tiny change just uses the uri instead of path when representing an Attribute as string. This is especially helpful in ValueAdmin...

@MyPyDavid
Copy link
Member

yes fine, but needs a rebase

@jochenklar jochenklar marked this pull request as ready for review November 14, 2024 15:07
@jochenklar jochenklar self-assigned this Nov 14, 2024
@jochenklar jochenklar added this to the RDMO 2.3.0 milestone Nov 14, 2024
@jochenklar
Copy link
Member Author

Rebased and ready (after tests are ok).

MyPyDavid
MyPyDavid approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@MyPyDavid MyPyDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@jochenklar jochenklar merged commit 295f7a2 into 2.3.0 Nov 19, 2024
19 checks passed
@jochenklar jochenklar deleted the update_attribute_admin branch November 19, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyPyDavid MyPyDavid MyPyDavid approved these changes

Assignees

@jochenklar jochenklar

Labels
None yet
Projects
None yet
Milestone
RDMO 2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jochenklar @MyPyDavid