Use EXPORT_CONTENT_DISPOSITION for project xml export #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An additional Problem with not downloading the file right away, is that users might copy-paste the content displayed in the browser, which is not the complete XML (e.g. namespaces are missing). |
|
this one is for 2.3.0 right? (was not for 2.2.2 or?) |
|
Mhm, we could have added that to 2.2.2, but its fine I guess. |
|
Or for |
|
Could you maybe rebase this on a proper release branch? |
jochenklar
force-pushed
the
project_xml_content_disposition
branch
from
7d8fde2
to
db31e9b
Compare
|
Rebased and ready (after tests are ok). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, an XML project export is always shown in the browser. Changed management XML exports to be always downloaded (controlled by
settings.EXPORT_CONTENT_DISPOSITION). This PR adds the same behavior for XML project exports.