-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jersey-joins-epilepsy12 #1105
Open
eatyourpeas
wants to merge
15
commits into
live
Choose a base branch
from
eatyourpeas/issue1100
base: live
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
jersey-joins-epilepsy12 #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…untry model fields, new migration to add boundaries, then another for the trust and the organisation. Note need extra migration to allow longer ods_code in Trust and empty fields in Country boundaries model
…d of jersey to 27700 from 4326 file source. Replace trust addition of Jersey with name rather than country object
…r organisation_id in CaseForm for validation of NHS number vs URN
…ell, the only way to do this is to pay for it as there are no open source datasets. Fix form to actually save the new URN (d'oh)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Jersey is in the Channel Islands and part of the UK but does not participate in the NHS. There are reciprocal agreements about some hospital treatment, but inpatient care is free only to people who have been resident for 6 months and have a Health Card.
Adding Jersey General Hospital to Epilepsy12 has implications for 7 parts of the audit
shape_files
folder. The boundaries do not map evenly to the Country model, so the Country model has been refactored to allow some fields to accept blank values. There are 3 migrations that have been created for this - the first to refactor the boundary/Country model and Trust model (to accept longer ODS codes), the second to map the Jersey shape file layers to the Country model and import the data, the third to add Jersey organisation and Trust to the database if does not exist.findmypostcode.co.uk
as a postcode validation and lookup service but RCPCH have more recently moved over to its own instance ofpostcodes.io
. Neither of these support Jersey so a new function is included to validate Jersey postcodes (all of which begin JE) with regex. This won't validate the postcode if it does not exist, but will ensure it is at least more or less in the right format. As part of this the seed functions and E12CaseFactory have been updated to generate Jersey postcodes from a random list.try..except
so that no value is stored.Case
modelunique_reference_number
which is (unique, obviously) but conditionally used in the forms, list views and so on if Jersey General Hospital and its patients are involved. TheCaseForm
now accepts anorganisation_id
parameter to check for this and has ais_jersey
flag to decide whether to allow users to store URNs or NHS Numbers for a given patient. Cleaning methods have been updated for this. I have not yet added any tests for this but it appears to work in the UI at least. The templates have been updated conditionally to reference URN vs NHS Numbers, as well as the filters.Other bits
The admin has been updated to allow search fields for Trust and Organisation models
Documentation changes (done or required as a result of this PR)
Documentation has been added on how to add .shp files and laymapping as this process is convoluted and easy to get wrong. I will add some of the detail above in separate commits.
Tests
There are no tests specifically for Jersey. I will do this in separate commits. Existing tests are all passing.
Related Issues
This closes #1100
New issues will be created for: