Skip to content

Commit

Permalink
Merge pull request #17 from seb36273/seb36273-fix-envar-typo
Browse files Browse the repository at this point in the history
Fix: small typo in sendmail.go
  • Loading branch information
rchakode authored May 15, 2022
2 parents 2526536 + 7016296 commit 37a12b6
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion app.yaml.sample
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ env_variables:
TEMPLATE_DEMO_REQUEST_REPLY: templates/template_reply_demo_request.html
TEMPLATE_CONTACT_REQUEST_REPLY: templates/template_reply_contact_request.html
SMTP_SERVER_ADDR: "smtp.mailgun.org:587"
SMTP_VERITY_CERT: true
SMTP_SKIP_VERIFY_CERT: false
SMTP_AUTHENTICATION_ENABLED: true
SMTP_CLIENT_USERNAME: "postmaster@example.com"
SMTP_CLIENT_PASSWORD: "postmasterSecretPassWord"
Expand Down
2 changes: 1 addition & 1 deletion docs/configuration-variables.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
Regardless of the deployment platform (Google App Engine, Kubernetes, Docker), the following configuration parameters must be provided when deploying hugo-mx-gateway.

* `SMTP_SERVER_ADDR`: Set the address of the SMTP server in the form of `host:port`. It's required that the SMTP server being supporting TLS.
* `SMTP_VERITY_CERT`: Tell whether the SMTP certificate should be validated against top level authorities. If you're using a self-signed certificate on the SMTP server, this value must be set to `false`.
* `SMTP_SKIP_VERIFY_CERT`: Tell whether the SMTP certificate should be validated against top level authorities. If you're using a self-signed certificate on the SMTP server, this value should be set to `true`.
* `SMTP_AUTHENTICATION_ENABLED`: Boolean (default: `true`) indicating whether SMTP authentication is required or not. If true, the variables `SMTP_CLIENT_USERNAME` and `SMTP_CLIENT_PASSWORD` are used the perform the authentication.
* `SMTP_CLIENT_USERNAME`: Set the username to connect to the SMTP server.
* `SMTP_CLIENT_PASSWORD`: Set the password to connect to the SMTP server.
Expand Down
2 changes: 1 addition & 1 deletion docs/deployment-on-docker.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Then apply the following command while setting the configuration variables appro
--publish 8080:8080 \
--name 'hugo-mx-gateway' \
-e SMTP_SERVER_ADDR="smtp.example.com:465" \
-e SMTP_VERITY_CERT=true \
-e SMTP_SKIP_VERIFY_CERT=false \
-e SMTP_CLIENT_USERNAME="postmaster@example.com" \
-e SMTP_CLIENT_PASSWORD="postmasterSecretPassWord" \
-e CONTACT_REPLY_EMAIL="noreply@example.com" \
Expand Down
2 changes: 1 addition & 1 deletion helm/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ replicaCount: 1

envs:
SMTP_SERVER_ADDR: "smtp.mailgun.org:587"
SMTP_VERITY_CERT: true
SMTP_SKIP_VERIFY_CERT: false
SMTP_CLIENT_USERNAME: "postmaster@example.com"
SMTP_CLIENT_PASSWORD: "postmasterSecretPassWord"
ALLOWED_ORIGINS: "127.0.0.1,example.com"
Expand Down
2 changes: 1 addition & 1 deletion sendmail.go
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ func (m *SendMailRequest) Execute() error {

// TLS config
tlsconfig := &tls.Config{
InsecureSkipVerify: viper.GetBool("SMTP_VERITY_CERT"),
InsecureSkipVerify: viper.GetBool("SMTP_SKIP_VERIFY_CERT"),
ServerName: smtpServerHost,
}

Expand Down

0 comments on commit 37a12b6

Please sign in to comment.