Skip to content

Commit

Permalink
Go Client: Update code to match changes in TimeTableRequest, and reen…
Browse files Browse the repository at this point in the history
…able CI (deephaven#4990)

* Revert "Temporarily disable updating generated go code from proto files (deephaven#4211)"

This reverts commit 3c4bea4.

* Update Go protos

* Update code to match changes in proto files
  • Loading branch information
kosak authored Dec 28, 2023
1 parent ecebae9 commit 8e61882
Show file tree
Hide file tree
Showing 24 changed files with 3,900 additions and 2,643 deletions.
23 changes: 10 additions & 13 deletions go/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -28,20 +28,17 @@ def compare = tasks.register('compareProtobuf', DiffTask) {
exclude 'internal/proto/**'
}
}
// Note that we've disabled updating the Go protobuf wiring until we have a maintainer to use the generated code correctly.
// fail a "check" build if these are out of date
tasks.getByName('quick').dependsOn(compare)

// Normally, we would fail a "check" build if these are out of date, but for now we will rely on integration tests.
//tasks.getByName('quick').dependsOn(compare)

// Also disable the update task so no one accidentally runs it from the root project
//tasks.register('updateProtobuf', Sync) {
// finalizedBy compare
// from configurations.go
// into layout.projectDirectory
// preserve {
// exclude 'internal/proto/**'
// }
//}
tasks.register('updateProtobuf', Sync) {
finalizedBy compare
from configurations.go
into layout.projectDirectory
preserve {
exclude 'internal/proto/**'
}
}


// start a grpc-api server
Expand Down
4 changes: 3 additions & 1 deletion go/internal/proto/application/application.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 11 additions & 9 deletions go/internal/proto/application/application_grpc.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions go/internal/proto/config/config.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion go/internal/proto/config/config_grpc.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 2 additions & 5 deletions go/internal/proto/console/console.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 7 additions & 1 deletion go/internal/proto/console/console_grpc.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions go/internal/proto/hierarchicaltable/hierarchicaltable.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion go/internal/proto/inputtable/inputtable.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion go/internal/proto/inputtable/inputtable_grpc.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 8e61882

Please sign in to comment.