Skip to content

Commit

Permalink
Disable pylint in CI
Browse files Browse the repository at this point in the history
Too noisy. It'd be a ton of work to fix all of the identified issues
so that the CI can pass - it's just not worth it. Up to now, I was
trying to have it only fail on errors, but apparently pylint reports
non-zero exits codes for more than just errors, so it's not clear how to
configure it at the moment (and not worth any more effort right now)
  • Loading branch information
raymondEhlers committed Feb 16, 2024
1 parent 5a22976 commit d6bc093
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 6 deletions.
14 changes: 14 additions & 0 deletions .github/matchers/pylint.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,19 @@
{
"problemMatcher": [
{
"severity": "warning",
"pattern": [
{
"regexp": "^([^:]+):(\\d+):(\\d+): ([A-DF-Z]\\d+): \\033\\[[\\d;]+m([^\\033]+).*$",
"file": 1,
"line": 2,
"column": 3,
"code": 4,
"message": 5
}
],
"owner": "pylint-warning"
},
{
"severity": "error",
"pattern": [
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,12 @@ jobs:
- uses: pre-commit/action@v3.0.1
with:
extra_args: --hook-stage manual --all-files
# NOTE: We only parse for errors with pylint because it's so noisy. Otherwise, the CI
# will practically always show as broken.
- name: Run PyLint
run: |
echo "::add-matcher::$GITHUB_WORKSPACE/.github/matchers/pylint.json"
pipx run nox -s pylint
# pylint is so noisy that there's no way the CI will ever pass if it's enabled.
# It's good to run when I think of it, but better to be a bit practical too. So I've disabled it for now
#- name: Run PyLint
# run: |
# echo "::add-matcher::$GITHUB_WORKSPACE/.github/matchers/pylint.json"
# pipx run nox -s pylint

checks:
name: Check Python ${{ matrix.python-version }} on ${{ matrix.runs-on }}
Expand Down

0 comments on commit d6bc093

Please sign in to comment.