-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RDoc-3009 [Node.js] Subscriptions > Advanced > Maintenance operations #1925
RDoc-3009 [Node.js] Subscriptions > Advanced > Maintenance operations #1925
Conversation
| Member | Type | Description | | ||
|-------------------------------------------|--------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------| | ||
| **query** | `string` | Subscription's RQL like query. | | ||
| **lastBatchAckTime** | `DateTime?` | Last time a batch processing progress was acknowledged. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Date?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I modified to a string
as I see here:
https://github.com/ravendb/ravendb-nodejs-client/blob/b82a20977fb56f0928e1eb918042b9e808cbd0ee/src/Documents/Subscriptions/SubscriptionState.ts#L4
| **nodeTag** | `string` | Processing server's node tag. | | ||
| **mentorNode** | `string` | The mentor node that was manually set. | | ||
| **subscriptionName** | `string` | The subscription's name, which is also its unique identifier. | | ||
| **subscriptionId** | `long` | Subscription's internal identifier (cluster's operation etag during subscription creation). | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
number?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right...
| **subscriptionId** | `long` | Subscription's internal identifier (cluster's operation etag during subscription creation). | | ||
| **changeVectorForNextBatchStartingPoint** | `string` | The Change Vector from which the subscription will begin sending documents.<br>This value is updated on batch acknowledgement and can also be set manually. | | ||
| **disabled** | `bool` | If `true`, subscription will not allow workers to connect. | | ||
| **lastClientConnectionTime** | `DateTime?` | Time when last client was connected (value sustained after disconnection). | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please review entire table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
} | ||
{ | ||
//region disable | ||
await documentStore.subscriptions.disable("subscriptionNameToDidable"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: Didable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Related issue
https://issues.hibernatingrhinos.com/issue/RDoc-3009/Node.js-Client-API-Data-subscriptions-Advanced-Maintenance-operations-Replace-C-samples
Notes for this PR:
There are still fixes to be applied to this article for all languages - to be done in a separate dedicated issue:
https://issues.hibernatingrhinos.com/issue/RDoc-3055/Client-API-Data-subscriptions-Advanced-Maintenance-operations-Fix-article
Node.js: @ml054