Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rom_data_lookup_inline function #2116

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Add rom_data_lookup_inline function #2116

wants to merge 2 commits into from

Conversation

will-v-pi
Copy link
Contributor

Add rom_data_lookup_inline function instead of rom_data_lookup, similar to rom_func_lookup_inline. The code is moved from bootrom.c to bootrom.h, with the rom_data_lookup function changed to a simple call of rom_data_lookup_inline, similar to rom_func_lookup.

Also use this inline lookup in flash_devinfo_ptr to avoid touching a function in flash during flash programming.

@will-v-pi
Move rom_data_lookup code into rom_data_lookup_inline
57a4983 
Allows ROM data lookup from FLASH/RAM sensitive code
@will-v-pi
Use rom_data_lookup_inline in flash_devinfo_ptr
fc3d66e 
Fixes bug introduced by raspberrypi#2082 where flash_devinfo_get_cs_size would use rom_data_lookup from flash during a __no_inline_not_in_flash_func
@will-v-pi will-v-pi mentioned this pull request Nov 29, 2024
Merged
@will-v-pi will-v-pi added this to the 2.1.1 milestone Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.1
Development

Successfully merging this pull request may close these issues.
1 participant
@will-v-pi