Parse included board files for pico_cmake_set declarations #2113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you have a
#include
within a board header file (eg in vgaboard.h) anypico_cmake_set
andpico_cmake_set_default
declarations in the included file aren't parsed (#2112)This fixes #2112 by parsing those files for these comments. It only parses includes which start with
boards/
, as it needs to extract the.h
file directly for use withpico_find_in_paths
.The inclusion order matches what would be expected (I think) - ie:
gives
PICO_PLATFORM = rp2040
frompico.h
,gives
PICO_PLATFORM = rp2350
,gives
PICO_FLASH_SIZE_BYTES = (8 * 1024 * 1024)
(matching the pre-processor defines), andgives
PICO_FLASH_SIZE_BYTES = (2 * 1024 * 1024)
frompico.h
(again matching the pre-processor defines)