Add board file for Pimoroni Pico Plus 2 W

[gonzalolarralde]

See the board details here: Pimoroni Pico Plus 2 W

This board is similar to pimoroni_pico_plus2_rp2350. I cannot reuse the same header file as this one does not have a direct wire to the LED, similar to pico_w it depends on the WiFi chip for it (compatibility, presumably).

I have no affiliation with Pimoroni, I just purchased a board and I'm using it with this modifications. I see that @ZodiusInfuser has posted some PRs for Pimoroni boards in the past so maybe they can chime in for review?

Fixes #2091

Thanks!

[peterharperuk]

@Gadgetoid

[lurch]

This is missing a // pico_cmake_set_default PICO_RP2350_A2_SUPPORTED line (which https://github.com/raspberrypi/pico-sdk/blob/develop/src/boards/include/boards/pimoroni_pico_plus2_rp2350.h does have).

Seems unlikely that PICO_VBUS_PIN and CYW43_PIN_WL_HOST_WAKE are both on pin 24?

Comparing this to https://github.com/raspberrypi/pico-sdk/blob/develop/src/boards/include/boards/pico2_w.h , this seem to be missing CYW43_DEFAULT_PIN_WL_DATA_OUT, CYW43_DEFAULT_PIN_WL_DATA_IN, etc.?

[kilograham]

Going to merge this as is for 2.1.0 release; it's likely better than nothing

[kilograham]

This is missing a // pico_cmake_set_default PICO_RP2350_A2_SUPPORTED line (which https://github.com/raspberrypi/pico-sdk/blob/develop/src/boards/include/boards/pimoroni_pico_plus2_rp2350.h does have).

Seems unlikely that PICO_VBUS_PIN and CYW43_PIN_WL_HOST_WAKE are both on pin 24?

Comparing this to https://github.com/raspberrypi/pico-sdk/blob/develop/src/boards/include/boards/pico2_w.h , this seem to be missing CYW43_DEFAULT_PIN_WL_DATA_OUT, CYW43_DEFAULT_PIN_WL_DATA_IN, etc.?

fixed all of these

[gonzalolarralde]

Thanks, I initially did this off picoroni_pico_plus2_rp2350.h on main, that's why a few things are off. I was completing the changes but seems like @kilograham took a pass on them.

[kilograham]

Ah yes, please review my latest change, as I'm about to merge to catch 2.1.0 release

[gonzalolarralde]

@kilograham checking the first few defines, the SPCE connector is not present in the Plus 2 W.

These should be removed

#define SPCE_TX_MISO_PIN 32
#define SPCE_RX_CS_PIN 33
#define SPCE_NETLIGHT_SCK_PIN 34
#define SPCE_RESET_MOSI_PIN 35
#define SPCE_PWRKEY_BL_PIN 36

These are OK

#define PIMORONI_PICO_PLUS2_W_USER_SW_PIN 45
#define PIMORONI_PICO_PLUS2_W_PSRAM_CS_PIN 47

[kilograham]

ah, then can you remove them and fix up the SPI pins to be correct

[gonzalolarralde]

@kilograham done. can you check if it looks fine for you?

[kilograham]

You say "default SPI to the same as pico2_w" ... no reason to assume that they are the same as Pico2 W - are there any SPI pins exposed on the Pico Plus 2 W? I don't have the schematic

[kilograham]

actually i looked on the website and this seems reasonable; i'm gonna merge

[gonzalolarralde]

@kilograham great, thanks for pushing this through!

[Gadgetoid]

Thanks for jumping on this, and nice timing.

I got a bit too caught up getting the wireless stuff working in MicroPython and trying to get a single build for our W and "non-W" variants. (Since both support wireless in theory)