Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ws2812 generated file #576

Closed
wants to merge 5 commits into from

Conversation

j3270
Copy link

@j3270 j3270 commented Nov 22, 2024

The file pico-examples/pio/ws2812/generated/ws2812.pio.h appears to be generated.

This PR stops tracking the file and adds it to .gitignore.

@lurch
Copy link
Contributor

lurch commented Nov 22, 2024

I think I asked about this once, and I was told that it was checked-in deliberately? 🤔
So see also #523

@peterharperuk
Copy link
Contributor

@lurch What was the reason? I keep forgetting to fix this and my approach would be to move generated files to the build tree.

@j3270
Copy link
Author

j3270 commented Nov 22, 2024

Hello,

I only noticed this because I brought the sdk and examples repos into my project repo as submodules.

I realized that wasn't the best approach and have now just created a 'workspace' folder where I have cloned the sdk, examples, picotool, and freeRTOS. My project will be another dir in the workspace repo and the modified file in the examples doesn't bother me as much.

I figured just adding the file to .gitignore was a little sledge hammerish and there was probably a better way using CMake. I would be happy to work on that, since I have the PR open, but not sure if I understand enough about CMake to do so. Any pointers to get me going in the right direction would be appreciated.

Thanks,
Justin

@kilograham
Copy link
Contributor

@lurch What was the reason? I keep forgetting to fix this and my approach would be to move generated files to the build tree.

These files are referenced by datasheet and other documentation so must exist. Strictly they don't need to be generated there by the actual build, but never had any problems before (though i could see an issue with multiple concurrent builds)

They should generate as they were; if not, then we should make sure the checked in versions are correct

@j3270
Copy link
Author

j3270 commented Nov 22, 2024

ws2812_example.zip

I did a little test.

Building the examples for pico or pico_w generates the same output.

What is checked in is different. I have to go back and look and see how to build for the rp2350 pcio. Maybe what is checked in is for that pico?

@j3270
Copy link
Author

j3270 commented Nov 22, 2024

Nope, building for pico2 generates the same output as pico, and pico_w.

It appears that what is checked in for that file is just different than what is generated for all three.

I can update this branch to track the file and check in the generated if you guys would like me to.

@peterharperuk
Copy link
Contributor

peterharperuk commented Nov 22, 2024

Yes, if you post the differences as a commit we can see what it is. For some reason it's not happening for me although I think I've seen this problem in the past.

Later: ah, you've posted the files...

@j3270 j3270 changed the title Ignore ws2812 generated file Update ws2812 generated file Nov 22, 2024
@j3270
Copy link
Author

j3270 commented Nov 22, 2024

I haven't actually run the example with that update, I will do later, have to run.

@kilograham
Copy link
Contributor

thx - in parallel i updated the generated/ file as i had it locally and was pushing some github action stuff... this PR will probably be empty if you rebase

@j3270 j3270 closed this Nov 23, 2024
@j3270
Copy link
Author

j3270 commented Nov 23, 2024

@kilograham done. I hope closing this PR was the appropriate thing to do.

Thanks

@j3270 j3270 deleted the IgnoreWS2812GeneratedFile branch November 23, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants