-
Notifications
You must be signed in to change notification settings - Fork 847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ws2812 generated file #576
Conversation
I think I asked about this once, and I was told that it was checked-in deliberately? 🤔 |
@lurch What was the reason? I keep forgetting to fix this and my approach would be to move generated files to the build tree. |
Hello, I only noticed this because I brought the sdk and examples repos into my project repo as submodules. I realized that wasn't the best approach and have now just created a 'workspace' folder where I have cloned the sdk, examples, picotool, and freeRTOS. My project will be another dir in the workspace repo and the modified file in the examples doesn't bother me as much. I figured just adding the file to .gitignore was a little sledge hammerish and there was probably a better way using CMake. I would be happy to work on that, since I have the PR open, but not sure if I understand enough about CMake to do so. Any pointers to get me going in the right direction would be appreciated. Thanks, |
These files are referenced by datasheet and other documentation so must exist. Strictly they don't need to be generated there by the actual build, but never had any problems before (though i could see an issue with multiple concurrent builds) They should generate as they were; if not, then we should make sure the checked in versions are correct |
I did a little test. Building the examples for pico or pico_w generates the same output. What is checked in is different. I have to go back and look and see how to build for the rp2350 pcio. Maybe what is checked in is for that pico? |
Nope, building for pico2 generates the same output as pico, and pico_w. It appears that what is checked in for that file is just different than what is generated for all three. I can update this branch to track the file and check in the generated if you guys would like me to. |
Yes, if you post the differences as a commit we can see what it is. For some reason it's not happening for me although I think I've seen this problem in the past. Later: ah, you've posted the files... |
I haven't actually run the example with that update, I will do later, have to run. |
thx - in parallel i updated the generated/ file as i had it locally and was pushing some github action stuff... this PR will probably be empty if you rebase |
8eb3b64
to
5872a42
Compare
@kilograham done. I hope closing this PR was the appropriate thing to do. Thanks |
The file pico-examples/pio/ws2812/generated/ws2812.pio.h appears to be generated.
This PR stops tracking the file and adds it to .gitignore.