Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output control on debug clock and data lines #146

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

julianagentile
Copy link

@julianagentile julianagentile commented Jul 10, 2024

The current release of the firmware leaves the clock and data lines with output enabled after deinit. When the probe is used as a component of a larger system/project, this can lead to unintended side effects such as interference with other communications (as the probe may still be trying to communicate), unintended operations, or signal interference.

Solution:

  • In probe_deinit(), disable output on the clock and data lines
  • In probe_init(), enable output on the clock and data lines

Note: this solution avoids needing to modify the PIO state machine implementation which is why I took this (much easier) route

src/probe.c Outdated Show resolved Hide resolved
src/probe.c Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants