Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TeamCity improvements #19684

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

TeamCity improvements #19684

wants to merge 2 commits into from

Conversation

sjanusz-r7
Copy link
Contributor

This PR improves the TeamCity Login Scanner based on some PR feedback that I've not addressed on the original PR.
It also adds in a logger to the base scanner class, which we can use to log messages inside of the scanner itself without needing to propagate results out to the caller, meaning more responsibility lies in the scanner.

Verification

Set up the teamcity target in Docker as per the original PR.

  • Start msfconsole
  • use teamcity login scanner
  • set ... all your values
  • run
  • ensure the timeout and logging works as expected
  • Ensure no other scanner modules break

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adfoster-r7 adfoster-r7 adfoster-r7 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjanusz-r7 @adfoster-r7