peer review

rapid7 · Nov 29, 2024 · d13bccc · d13bccc
1 parent 4ebc6f1
commit d13bccc
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 17 deletions.
diff --git a/documentation/modules/exploit/linux/misc/asterisk_ami_originate_auth_rce.md b/documentation/modules/exploit/linux/misc/asterisk_ami_originate_auth_rce.md
@@ -41,7 +41,7 @@ Default parking lot is called "Default lot" in the website interface, however it
 
 1. Install the application
 1. Start msfconsole
-1. Do: `use exploit/linux/misc/asterisk_ami_originate_auth_rce `
+1. Do: `use exploit/linux/misc/asterisk_ami_originate_auth_rce`
 1. Do: `set rhosts <rhost>`
 1. Do: `set lhost <lhost>`
 1. Do: `set username <username>`

diff --git a/lib/msf/core/exploit/remote/asterisk.rb b/lib/msf/core/exploit/remote/asterisk.rb
@@ -35,11 +35,8 @@ def send_command(cmd = '')
       res
     rescue Timeout::Error
       print_error "Timeout (#{timeout} seconds)"
-    rescue StandardError
-      # unsure why but getting no implicit conversion of nil into String with the following code
-      # this can be tested with successful exploitation of asterisk_ami_originate_auth_rce module
-      # print_error e.message
-      print_error('Unknown exception')
+    rescue StandardError => e
+      print_error e.message
     end
 
     #

diff --git a/modules/exploits/linux/misc/asterisk_ami_originate_auth_rce.rb b/modules/exploits/linux/misc/asterisk_ami_originate_auth_rce.rb
@@ -201,15 +201,4 @@ def on_new_session(client)
     super
     print_good("!!!Don't forget to clean evidence from #{datastore['CONF']}!!!")
   end
-
-  private
-
-  def username
-    datastore['USERNAME']
-  end
-
-  def password
-    datastore['PASSWORD']
-  end
-
 end