-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Animated PNG (APNG) read support #252
base: master
Are you sure you want to change the base?
Conversation
Debian includes APNG support with libpng, but homebrew and other platforms don't. The fallback wrap should also include APNG support.
endif | ||
else # Using fallback | ||
if can_apply_patch == false | ||
warning(meson_too_old_msg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be an error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you really wanted to make it work using an older version you could apply it manually and there's no point in preventing that. Both uses of meson_too_old_msg
should the same (both warning()
or error()
) but I haven't decided yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, which should it be, warning or error?
Keen to see this PR merged
hopefully waiting for this |
I'm still working out some internal details before I push code to this branch, shortly after I will be making another PR for encode support, that one will go much quicker. |
Great, thanks for the update. I'm wanting to make some utilities which generate specific PNG files, including APNG, to use in testing. I can use |
Fixes #4