forked from HHS/TANF-app
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate PLG to Prod #3276
Merged
Merged
Migrate PLG to Prod #3276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update .ini to use internal domain - Add nginx config for proxying prod Grafana
- turn off tests
elipe17
added
dev
devops
cloud
frontend
backend
Deploy with CircleCI-raft
Deploy to https://tdp-frontend-raft.app.cloud.gov through CircleCI
labels
Nov 13, 2024
- fix location error
elipe17
added
Deploy with CircleCI-raft
Deploy to https://tdp-frontend-raft.app.cloud.gov through CircleCI
and removed
Deploy with CircleCI-raft
Deploy to https://tdp-frontend-raft.app.cloud.gov through CircleCI
labels
Nov 13, 2024
[DONE] Attach to 3222 |
11 tasks
- update plg/deploy.sh to handle all prod based networking since net-pols are persistent - Remove unnecessary scrape config from prometheus config
- Gave loki 1GB memory
elipe17
added
Deploy with CircleCI-raft
Deploy to https://tdp-frontend-raft.app.cloud.gov through CircleCI
and removed
Deploy with CircleCI-raft
Deploy to https://tdp-frontend-raft.app.cloud.gov through CircleCI
labels
Nov 14, 2024
elipe17
added
Deploy with CircleCI-raft
Deploy to https://tdp-frontend-raft.app.cloud.gov through CircleCI
and removed
Deploy with CircleCI-raft
Deploy to https://tdp-frontend-raft.app.cloud.gov through CircleCI
labels
Nov 14, 2024
ADPennington
added
Deploy with CircleCI-qasp
Deploy to https://tdp-frontend-qasp.app.cloud.gov through CircleCI
and removed
Deploy with CircleCI-raft
Deploy to https://tdp-frontend-raft.app.cloud.gov through CircleCI
labels
Nov 21, 2024
@elipe17 cf cli issue in the pipeline affecting the deployment on this branch. |
ADPennington
added
Blocked
Label for Pull Requests that are currently blocked by a dependency
and removed
Deploy with CircleCI-qasp
Deploy to https://tdp-frontend-qasp.app.cloud.gov through CircleCI
labels
Nov 22, 2024
elipe17
removed
the
Blocked
Label for Pull Requests that are currently blocked by a dependency
label
Nov 22, 2024
elipe17
added
Deploy with CircleCI-qasp
Deploy to https://tdp-frontend-qasp.app.cloud.gov through CircleCI
Deploy with CircleCI-raft
Deploy to https://tdp-frontend-raft.app.cloud.gov through CircleCI
labels
Nov 22, 2024
ADPennington
removed
Deploy with CircleCI-raft
Deploy to https://tdp-frontend-raft.app.cloud.gov through CircleCI
Deploy with CircleCI-qasp
Deploy to https://tdp-frontend-qasp.app.cloud.gov through CircleCI
labels
Nov 25, 2024
ADPennington
added
the
Deploy with CircleCI-qasp
Deploy to https://tdp-frontend-qasp.app.cloud.gov through CircleCI
label
Nov 25, 2024
- added extra promtail config to prove filtering works
ADPennington
added
Deploy with CircleCI-qasp
Deploy to https://tdp-frontend-qasp.app.cloud.gov through CircleCI
and removed
Deploy with CircleCI-qasp
Deploy to https://tdp-frontend-qasp.app.cloud.gov through CircleCI
labels
Nov 27, 2024
ADPennington
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elipe17 this LGTM! testing notes below and one question.
- Confirmed ability to get to grafana with sys admin permissions
- Confirmed inability to get to grafana w/o sys admin permissions
- Confirmed PLG stack not available in
tanf-dev
space (viacf apps
) - Confirmed PLG apps only available in
tanf-prod
space - Confirmed the following least privilege protocols over access to grafana are in-place:
- Access to grafana requires to levels of sign-in. First, sign-in via TDP authentication service, then approved users with developer or sys admin permissions can access grafana endpoint. Second, must sign-in with grafana-specific user/pass credentials.
- admin/ofa users have more visibility than non-admin users
- non-admin user has visibility to dev and staging logs
ADPennington
added
Ready to Merge
and removed
Deploy with CircleCI-qasp
Deploy to https://tdp-frontend-qasp.app.cloud.gov through CircleCI
QASP Review
labels
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Pull request closes PLG Production Migration #3222
How to Test
Deliverables
More details on how deliverables herein are assessed included here.
Deliverable 1: Accepted Features
Checklist of ACs:
Deliverable 2: Tested Code
CodeCov Report
comment in PR)CodeCov Report
comment in PR)Deliverable 3: Properly Styled Code
Deliverable 4: Accessible
iamjolly
andttran-hub
using Accessibility Insights reveal any errors introduced in this PR?Deliverable 5: Deployed
Deliverable 6: Documented
Deliverable 7: Secure
Deliverable 8: User Research
Research product(s) clearly articulate(s):