Random fiixes #100
Merged
Random fiixes #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit babdae2.
gh action, doc, add readme to rbuildignore + man/figures as pkgdown needs this. update badge + remove travis
|
Thanks! Sometimes we need a little regression before we advance things :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #99.
Since pkgdown requires images to be in man/figures, I replaced them there, but if we want to avoid the note about the size issue, we have to add this to .Rbuildignore, which means we also have to add README.md..
This should fix both the CRAN note about size + the images not appearing on the pkgdown site.
I took the liberty to update the doc to fix CI, as well as updating links and GitHub actions