Rename new Either.Upcast method to From

qwertie · Apr 5, 2020 · d2c9c6d · d2c9c6d
1 parent ac3a600
commit d2c9c6d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/Core/Loyc.Interfaces/Concrete/Either.cs b/Core/Loyc.Interfaces/Concrete/Either.cs
@@ -57,10 +57,12 @@ private Either(bool hasLeft, L left, R right)
 		/// <remarks>
 		/// Sadly, automatically upcasting value types to reference types doesn't seem possible.
 		/// </remarks>
-		public static Either<L, R> Upcast<L2, R2>(Either<L2,R2> x)
+		public static Either<L, R> From<L2, R2>(Either<L2,R2> x)
 			where L2 : L 
 			where R2 : R
 			=> new Either<L, R>(x._hasLeft, x._left, x._right);
+
+		/// <summary>Converts an Either to another with different types.</summary>
 		public Either<L2, R2> Select<L2, R2>(Func<L, L2> selectL, Func<R, R2> selectR)
 			=> _hasLeft ? new Either<L2, R2>(selectL(_left)) : selectR(_right);
 	}

diff --git a/Core/Tests/Essentials/Either.cs b/Core/Tests/Essentials/Either.cs
@@ -48,8 +48,8 @@ public void CastTest()
 		{
 			Either<string, ArgumentException> s = "Hi";
 			Either<string, ArgumentException> e = new ArgumentException();
-			var s2 = Either<object, Exception>.Upcast(s);
-			var e2 = Either<object, Exception>.Upcast(e);
+			var s2 = Either<object, Exception>.From(s);
+			var e2 = Either<object, Exception>.From(e);
 			Assert.AreEqual("Hi", s2.Value);
 			Assert.IsTrue(e2.Value is ArgumentException);