-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic responsive layout + minor style upgrades #1
Conversation
Thanks a lot Jamie! I've been busy the last few days with some other things, but this looks pretty good. I'll try to have a proper look soon and get it merged, I just want to tweak a few things first. |
I think I'm happy enough with this now to merge it and push it to production, but there are a few issues I'd still like to fix:
|
Great - I see you moved a few things around after the merge too, did that fix everything or is there still anything you'd like me to look at for a future PR? |
I think I've got the grid layout looking better now, but the other two issues are still there. If you have any thoughts they would be welcome. |
Hi Andrew - great project, thanks for doing this!
I saw your call-out on FB for collaboration on the UI side of things, so this PR adds some basic responsivity (mostly for the benefit of mobile users) plus some small style upgrades. I've kept it reasonably faithful to your original style so far, and I've not touched the original
main.css
or element layout at all yet - but I think the HTML could benefit from some semantic restructuring for accessibility purposes and to unlock more creative possibilities with the CSS. Happy to work on this further with you if you're up for it! :)