extra logging first draft

[borkabu]

Fixes #824
Added new configuration setting FieldValidationLogging.
When it is Y, then prints log messages instead of failing validation for unknown user defined fields, unknown fields and unknown enum values.

[chrjohn]

We also need to have the new setting in
https://github.com/quickfix-j/quickfixj/blob/master/quickfixj-core/src/main/doc/usermanual/usage/configuration.html

[chrjohn]

I'm still thinking about a better way to do the logging. As it is now there is no correlation to the actual message and it could be hard to see which message is actually affected. Maybe we could do this via the sessions's log? But still thinking about how this could be accomplished.

[borkabu]

Updated documentation

[borkabu]

I'm still thinking about a better way to do the logging. As it is now there is no correlation to the actual message and it could be hard to see which message is actually affected. Maybe we could do this via the sessions's log? But still thinking about how this could be accomplished.

If I understand correctly, DataDictionary is independent of Session. Validation of message can be done, without having existing Session. I see no obstacles of printing message related information. In my case, this logging is to warn about schema being out of sync, so message itself is not really important.

[philipwhiuk]

If I understand correctly, DataDictionary is independent of Session. Validation of message can be done, without having existing Session. I see no obstacles of printing message related information. In my case, this logging is to warn about schema being out of sync, so message itself is not really important.

But if you have lots of sessions it's necessary to identify which counter-party is sending out-of-spec messages. Doing it this way you'll have to go back and find the message in the log in a separate log line. That's terrible.

A nicer way might be a callback:

Something a little like:

onOutOfSpecMessage(Message m, int tag, String value);

then at least the app can decide to look it up from the Message.

You can implement a pure logging handler if that's all you need.

[borkabu]

If I understand correctly, DataDictionary is independent of Session. Validation of message can be done, without having existing Session. I see no obstacles of printing message related information. In my case, this logging is to warn about schema being out of sync, so message itself is not really important.

But if you have lots of sessions it's necessary to identify which counter-party is sending out-of-spec messages. Doing it this way you'll have to go back and find the message in the log in a separate log line. That's terrible.

A nicer way might be a callback:

Something a little like:

onOutOfSpecMessage(Message m, int tag, String value);

then at least the app can decide to look it up from the Message.

You can implement a pure logging handler if that's all you need.

I have kind of warmed up to an idea of callback. I see there would be a default callback with a default logger, when validation is used outside of a session and "integrated" session callback with session logger, when validation is inside session.