Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read Scala options from pom.xml #27

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Read Scala options from pom.xml #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions deployment/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
<project xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>io.quarkiverse.scala</groupId>
Expand Down Expand Up @@ -38,6 +39,12 @@
<artifactId>scala3-interfaces</artifactId>
<version>3.3.1</version>
</dependency>

<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-model</artifactId>
<version>3.9.6</version>
</dependency>
</dependencies>
<build>
<plugins>
Expand All @@ -55,4 +62,4 @@
</plugin>
</plugins>
</build>
</project>
</project>
72 changes: 61 additions & 11 deletions ...yment/src/main/java/io/quarkiverse/scala/scala3/deployment/Scala3CompilationProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package io.quarkiverse.scala.scala3.deployment;

import java.io.File;
import java.io.FileReader;
import java.lang.reflect.Method;
import java.nio.file.Path;
import java.util.ArrayList;
Expand All @@ -11,6 +12,10 @@
import java.util.Set;
import java.util.stream.Collectors;

import org.apache.maven.model.Model;
import org.apache.maven.model.Plugin;
import org.apache.maven.model.io.xpp3.MavenXpp3Reader;
import org.codehaus.plexus.util.xml.Xpp3Dom;
import org.jboss.logging.Logger;

import dotty.tools.dotc.interfaces.AbstractFile;
Expand Down Expand Up @@ -58,12 +63,56 @@
*/
public class Scala3CompilationProvider implements CompilationProvider {

private final Logger log = Logger.getLogger(Scala3CompilationProvider.class);
private final static Logger log = Logger.getLogger(Scala3CompilationProvider.class);

// There's currently no way for this kind of extension to use Config providers
// So the best way I can come up with passing compiler args is by accepting an ENV var
private static final String COMPILER_ARGS_ENV_VAR = "QUARKUS_SCALA3_COMPILER_ARGS";
private static final Optional<List<String>> COMPILER_ARGS = getCompilerArgsFromEnv();
static String COMPILER_ARGS_ENV_VAR = "QUARKUS_SCALA3_COMPILER_ARGS";
// Parse the xml file to get the Scala compiler args
private static final Optional<List<String>> COMPILER_ARGS = getCompilerArgs();

private static Optional<List<String>> getCompilerArgs() {
String projectRoot = System.getProperty("user.dir");
log.info("User dir: " + projectRoot);

// If the environment variable is set, use that
if (System.getenv(COMPILER_ARGS_ENV_VAR) != null) {
log.info("Compiler args from env: " + System.getenv(COMPILER_ARGS_ENV_VAR));
return getCompilerArgsFromEnv();
}

// Check if pom.xml exists
File pom = new File(projectRoot, "/pom.xml");
if (!pom.exists()) {
log.info("No pom.xml found, using compiler args from env");
return getCompilerArgsFromEnv();
} else {
// Scala args is in pom.xml under project -> build -> plugins ->
// plugin(scala-maven-plugin) -> configuration -> args
MavenXpp3Reader reader = new MavenXpp3Reader();
try {
Model model = reader.read(new FileReader(pom));
List<String> compilerArgs = new ArrayList<>();
Plugin plugin = model.getBuild().getPlugins().stream()
.filter(p -> p.getArtifactId().equals("scala-maven-plugin")).findFirst().get();

Xpp3Dom configuration = (Xpp3Dom) plugin.getConfiguration();
for (Xpp3Dom arg : configuration.getChild("args").getChildren()) {
if (arg.getValue() == null) {
continue;
}
compilerArgs.add(arg.getValue());
}

log.info("Compiler args from pom.xml: " + compilerArgs);
return Optional.of(compilerArgs);

} catch (Exception e) {
log.error(e.getMessage());
log.error(e.getStackTrace());

return Optional.empty();
}
}
}

private static Optional<List<String>> getCompilerArgsFromEnv() {
String compilerArgsString = System.getenv(COMPILER_ARGS_ENV_VAR);
Expand Down Expand Up @@ -141,18 +190,19 @@ public void report(Diagnostic diag) {
}
}

// This is a no-op implementation right now, the super() calls invoke void methods
// This is a no-op implementation right now, the super() calls invoke void
// methods
// But it's useful for future reference I think
class CustomCompilerCallback implements CompilerCallback {

/**
* Called when a class has been generated.
*
* @param source The source file corresponding to this class. Example:
* ./src/library/scala/collection/Seq.scala
* @param source The source file corresponding to this class. Example:
* ./src/library/scala/collection/Seq.scala
* @param generatedClass The generated classfile for this class. Example:
* ./scala/collection/Seq$.class
* @param className The name of this class.
* ./scala/collection/Seq$.class
* @param className The name of this class.
*/
@Override
public void onClassGenerated(SourceFile source, AbstractFile generatedClass, String className) {
Expand All @@ -163,7 +213,7 @@ public void onClassGenerated(SourceFile source, AbstractFile generatedClass, Str
* Called when every class for this file has been generated.
*
* @param source The source file. Example:
* ./src/library/scala/collection/Seq.scala
* ./src/library/scala/collection/Seq.scala
*/
@Override
public void onSourceCompiled(SourceFile source) {
Expand Down
3 changes: 2 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
<project xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>io.quarkiverse</groupId>
Expand Down