Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for reading configuration from a Secrets Manager #771

Closed

Conversation

scrocquesel
Copy link
Member

Closes #510

@scrocquesel scrocquesel marked this pull request as draft May 27, 2023 22:53
@scrocquesel
Copy link
Member Author

@MedRAQAOUI I have submitted a draft PR to support the secrets manager as a configuration source. Could you please take a look at it?

Currently, it is quite simple. It retrieves all secrets and only manages secretString. Since I don't use the secrets manager myself, I don't have a real use case to explore further options. For instance, should I add filters with tag key/value or specify the owning service?

Your comments are warmly welcome.

@scrocquesel scrocquesel marked this pull request as ready for review July 2, 2023 18:46
@scrocquesel scrocquesel marked this pull request as draft July 10, 2023 21:10
@scrocquesel scrocquesel force-pushed the secretsmanager-config branch 2 times, most recently from 1735c29 to 72d8713 Compare July 23, 2023 15:24
@github-actions
Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Sep 22, 2023
@MedRAQAOUI
Copy link

Hi @scrocquesel ,

Thank you for taking care of this subject.

For my part I resolved this problem through the implementation of the 2 objects io.smallrye.config.ConfigSourceFactory
and io.smallrye.config.common.AbstractConfigSource and also the 3 dependencies
implementation platform('software.amazon.awssdk:bom:2.19.29')
implementation 'software.amazon.awssdk:secretsmanager'
implementation 'software.amazon.awssdk:sts'

Best reguards,
RAQAOUI MOHAMED

@github-actions github-actions bot removed the stale label Sep 23, 2023
Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Nov 26, 2023
Copy link

This PR was closed because it has been stalled for 10 days with no activity.

@github-actions github-actions bot closed this Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get secret as environnement variable from aws secretsmanager
2 participants