Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More unittest #59

Merged
merged 8 commits into from
Sep 9, 2023
Merged

More unittest #59

merged 8 commits into from
Sep 9, 2023

Conversation

quangdangfit
Copy link
Owner

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented Sep 9, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 14 Code Smells

72.1% 72.1% Coverage
0.9% 0.9% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Patch coverage: 97.53% and project coverage change: +6.94% 🎉

Comparison is base (cd0abc2) 74.88% compared to head (6719bd9) 81.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
+ Coverage   74.88%   81.83%   +6.94%     
==========================================
  Files          27       29       +2     
  Lines        1282     1310      +28     
==========================================
+ Hits          960     1072     +112     
+ Misses        207      112      -95     
- Partials      115      126      +11     
Files Changed Coverage Δ
internal/order/repository/order.go 92.50% <93.10%> (+18.01%) ⬆️
internal/order/port/http/routes.go 100.00% <100.00%> (ø)
internal/order/repository/product.go 100.00% <100.00%> (ø)
internal/product/port/http/handlers.go 100.00% <100.00%> (+6.25%) ⬆️
internal/product/port/http/routes.go 100.00% <100.00%> (ø)
internal/product/repository/product.go 100.00% <100.00%> (+15.00%) ⬆️
internal/server/http/server.go 38.46% <100.00%> (ø)
internal/user/port/grpc/handlers.go 100.00% <100.00%> (ø)
internal/user/port/grpc/server.go 100.00% <100.00%> (ø)
internal/user/port/http/routes.go 100.00% <100.00%> (ø)
... and 2 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Sep 9, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 14 Code Smells

72.1% 72.1% Coverage
0.9% 0.9% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@quangdangfit quangdangfit merged commit 04a4a9c into master Sep 9, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant