-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support Braket noise model #160
Conversation
@speller26 I tried to implement the UX
One concern I have is the
will try to add the noise model to all the returned backends. Looking for some feedback around this point. |
def __init__( | ||
self, | ||
name: str = "default", | ||
noise_model: Optional[BraketNoiseModel] = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a qiskit noise model that we would translate to Braket before L88.
**fields: extra fields | ||
""" | ||
super().__init__(name=name, **fields) | ||
self.backend_name = name | ||
self._local_device = LocalSimulator(backend=self.backend_name) | ||
self._local_device.set_noise_model(noise_model) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have a self.set_noise_model(noise_model: QiskitNoiseModel)
and translate noise_model
and apply it to self._local_device
.
Closing this PR. The Braket backend in Qiskit should accept Qiskit noise model instead of Braket noise model. |
Summary
Support Braket noise model for Braket backend. Solves half of #89. Still need to add support to Qiskit noise model which can be a separate PR.
Details and comments