Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BIPMapper #5

Merged
merged 6 commits into from
Aug 11, 2023
Merged

Update BIPMapper #5

merged 6 commits into from
Aug 11, 2023

Conversation

amyels
Copy link
Contributor

@amyels amyels commented Aug 10, 2023

transpile, BIPMapping, and BIPMappingModel all behave as expected with various inputs

 On branch update-bip
	modified:   qiskit_bip_mapper/bip_mapping.py
	modified:   qiskit_bip_mapper/bip_model.py
@CLAassistant
Copy link

CLAassistant commented Aug 10, 2023

CLA assistant check
All committers have signed the CLA.

@gnannicini
Copy link
Collaborator

There is an issue with file formatting:

lint: commands[0]> black --check qiskit_bip_mapper setup.py
would reformat qiskit_bip_mapper/bip_mapping.py
would reformat qiskit_bip_mapper/bip_model.py

This is blocking the merge. Can you have a quick look at it? Running the automatic formatting tool should be enough.

amyels and others added 2 commits August 11, 2023 10:22
@amyels
Copy link
Contributor Author

amyels commented Aug 11, 2023

There is an issue with file formatting:

lint: commands[0]> black --check qiskit_bip_mapper setup.py would reformat qiskit_bip_mapper/bip_mapping.py would reformat qiskit_bip_mapper/bip_model.py

This is blocking the merge. Can you have a quick look at it? Running the automatic formatting tool should be enough.

reformatted with black, should work now!

@gnannicini
Copy link
Collaborator

Now these are reported as errors:

qiskit_bip_mapper/bip_mapping.py:168:9: D205 1 blank line required between summary line and description
qiskit_bip_mapper/bip_mapping.py:311:9: D205 1 blank line required between summary line and description
qiskit_bip_mapper/bip_mapping.py:311:9: D209 [] Multi-line docstring closing quotes should be on a separate line
qiskit_bip_mapper/bip_model.py:47:9: D202 [
] No blank lines allowed after function docstring (found 1)
qiskit_bip_mapper/bip_model.py:47:9: D205 1 blank line required between summary line and description
qiskit_bip_mapper/bip_model.py:47:9: D212 [] Multi-line docstring summary should start at the first line
qiskit_bip_mapper/bip_model.py:47:9: D415 [
] First line should end with a period, question mark, or exclamation point
qiskit_bip_mapper/bip_model.py:730:15: UP011 [] Unnecessary parameters to functools.lru_cache
qiskit_bip_mapper/bip_model.py:738:15: UP011 [
] Unnecessary parameters to functools.lru_cache
Found 9 errors.
[*] 6 potentially fixable with the --fix option.
lint: exit 1 (0.03 seconds) /home/runner/work/qiskit-bip-mapper/qiskit-bip-mapper> ruff check qiskit_bip_mapper setup.py pid=2030
.pkg: _exit> python /opt/hostedtoolcache/Python/3.8.17/x64/lib/python3.8/site-packages/pyproject_api/_backend.py True pbr.build
lint: FAIL code 1 (46.89=setup[46.41]+cmd[0.45,0.03] seconds)
evaluation failed :( (47.59 seconds)
Error: Process completed with exit code 1.

@amyels
Copy link
Contributor Author

amyels commented Aug 11, 2023

Now these are reported as errors:

qiskit_bip_mapper/bip_mapping.py:168:9: D205 1 blank line required between summary line and description qiskit_bip_mapper/bip_mapping.py:311:9: D205 1 blank line required between summary line and description qiskit_bip_mapper/bip_mapping.py:311:9: D209 [] Multi-line docstring closing quotes should be on a separate line qiskit_bip_mapper/bip_model.py:47:9: D202 [] No blank lines allowed after function docstring (found 1) qiskit_bip_mapper/bip_model.py:47:9: D205 1 blank line required between summary line and description qiskit_bip_mapper/bip_model.py:47:9: D212 [] Multi-line docstring summary should start at the first line qiskit_bip_mapper/bip_model.py:47:9: D415 [] First line should end with a period, question mark, or exclamation point qiskit_bip_mapper/bip_model.py:730:15: UP011 [] Unnecessary parameters to functools.lru_cache qiskit_bip_mapper/bip_model.py:738:15: UP011 [] Unnecessary parameters to functools.lru_cache Found 9 errors. [*] 6 potentially fixable with the --fix option. lint: exit 1 (0.03 seconds) /home/runner/work/qiskit-bip-mapper/qiskit-bip-mapper> ruff check qiskit_bip_mapper setup.py pid=2030 .pkg: _exit> python /opt/hostedtoolcache/Python/3.8.17/x64/lib/python3.8/site-packages/pyproject_api/_backend.py True pbr.build lint: FAIL code 1 (46.89=setup[46.41]+cmd[0.45,0.03] seconds) evaluation failed :( (47.59 seconds) Error: Process completed with exit code 1.

all issues should be fixed now

@gnannicini gnannicini merged commit 1c007de into qiskit-community:main Aug 11, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants