Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resources tags #429

Merged
merged 10 commits into from
Jun 19, 2024
Merged

Resources tags #429

merged 10 commits into from
Jun 19, 2024

Conversation

Xpirix
Copy link
Collaborator

@Xpirix Xpirix commented Jun 13, 2024

This is the proposed fix for #393

Changes summary

  • Add tags feature for all resource types (Styles, Projects, Models, 3D models, Layer definition)
  • New optional field tags in the upload and update form

Please find below a screen recording of the tags feature for the styles hub as an example:

style-tags.mov

@Xpirix Xpirix requested a review from dimasciput June 13, 2024 10:59
@Xpirix Xpirix marked this pull request as ready for review June 13, 2024 10:59
@dimasciput
Copy link
Collaborator

@Xpirix could you add more tests please? Especially for this function qgis-app/models/templatetags/resources_tagcloud.py

@Xpirix
Copy link
Collaborator Author

Xpirix commented Jun 17, 2024

@dimasciput Sure, I'll do that

@Xpirix Xpirix marked this pull request as draft June 17, 2024 07:41
@Xpirix Xpirix marked this pull request as ready for review June 18, 2024 07:32
@nyalldawson
Copy link
Contributor

Thank you! This looks great!

@dimasciput dimasciput merged commit 148aebe into qgis:master Jun 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants