Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix svg icons display issue in plugin list and plugin detail #348

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

Xpirix
Copy link
Collaborator

@Xpirix Xpirix commented Jan 25, 2024

Changes summary:

  • Show SVG icons directly in the plugins list and the plugin detail page since solr-thumbnail doesn't support them

QuickOSM is an example of a plugin that uses an SVG icon:

image

image

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6d03c84) 36.94% compared to head (e0dc8e2) 82.68%.

Files Patch % Lines
qgis-app/plugins/templatetags/plugin_utils.py 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #348       +/-   ##
===========================================
+ Coverage   36.94%   82.68%   +45.73%     
===========================================
  Files         106      142       +36     
  Lines        4504     5503      +999     
===========================================
+ Hits         1664     4550     +2886     
+ Misses       2840      953     -1887     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gustry
Copy link
Contributor

Gustry commented Jan 25, 2024

Thanks @Xpirix ! 👍

@Xpirix
Copy link
Collaborator Author

Xpirix commented Jan 25, 2024

My pleasure.

@dimasciput dimasciput merged commit 5054f5d into qgis:master Jan 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants