Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closes #1999,fix GetCellRichText strconv.Atoi error because of null value (#1999) #2000

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

liuwangchao
Copy link
Contributor

PR Details

fix GetCellRichText strconv.Atoi error because of null value

Description

Related Issue

#1999

Motivation and Context

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@xuri xuri added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 27, 2024
- Simplify code for the GetCellRichText function
- Add comments for the variable ErrPasswordLengthInvalid
@xuri xuri added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 27, 2024
@xuri xuri linked an issue Sep 27, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.32%. Comparing base (41c7dd3) to head (cda5a4a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2000   +/-   ##
=======================================
  Coverage   99.32%   99.32%           
=======================================
  Files          32       32           
  Lines       25332    25332           
=======================================
  Hits        25160    25160           
  Misses         92       92           
  Partials       80       80           
Flag Coverage Δ
unittests 99.32% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution. I made some changes and added unit tests based on your branch.

- Update GitHub Actions workflow configuration, test on Go 1.23.x
@xuri xuri merged commit bebb802 into qax-os:master Sep 27, 2024
41 checks passed
@liuwangchao
Copy link
Contributor Author

So fast👍, and it's my pleasure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
No open projects
Status: Bugfix
Development

Successfully merging this pull request may close these issues.

GetCellRichText strconv.Atoi error because of null value
2 participants