Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update lightning example to lightning 2.0 #603

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: update lightning example to lightning 2.0 #603

wants to merge 3 commits into from

Conversation

dwahdany
Copy link
Contributor

@dwahdany dwahdany commented Sep 11, 2023 •
edited
Loading

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs change / refactoring / dependency upgrade

Motivation and Context / Related issue

Updates the lightning example to use a less hacky way to change datamodules.
Lightning-AI/pytorch-lightning#10430

How Has This Been Tested (if it applies)

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
  • All tests passed, and additional code has been covered with new tests.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 11, 2023
@facebook-github-bot
Copy link
Contributor

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

karthikprasad
karthikprasad requested changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@karthikprasad karthikprasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! There is a minor bug in the variable name. I'm surprised the integration test passed despite this though.

examples/mnist_lightning.py Outdated Show resolved Hide resolved
@facebook-github-bot
Copy link
Contributor

@lsc64 has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@dwahdany
Copy link
Contributor Author

dwahdany commented Oct 5, 2023

Thanks for the PR! There is a minor bug in the variable name. I'm surprised the integration test passed despite this though.

One could think it’s possible to add two lines without a major oversight, but here we are… thanks, I’ve changed it!

@facebook-github-bot
Copy link
Contributor

@lsc64 has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@lsc64 has updated the pull request. You must reimport the pull request before landing.

@dwahdany
Copy link
Contributor Author

dwahdany commented Jan 5, 2024

friendly ping @karthikprasad
I think your review is implemented. let me know if something else is missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikprasad karthikprasad Awaiting requested review from karthikprasad

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dwahdany @facebook-github-bot @karthikprasad