Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'abandon_on_cancel' to to_thread.run_sync #96

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

Hnasar
Copy link
Contributor

@Hnasar Hnasar commented Sep 16, 2024

@tjstum
Copy link
Member

tjstum commented Sep 17, 2024

Hi!

Thanks for sending this. We should remove the cancellable= argument, which is deprecated (and issues warnings at runtime) along with this addition.

@jakkdl
Copy link
Member

jakkdl commented Sep 18, 2024

reminder that trio-typing is not really maintained, as upstream trio has incorporated type hints. Once mypy supports typing Nursery.start we will sunset this repo, see #75 (comment)

A new parameter name was added
https://trio.readthedocs.io/en/stable/history.html#id15

And cancellable is now deprecated and causes a warning, so remote the
old parameter name.
@tjstum
Copy link
Member

tjstum commented Sep 24, 2024

Great, thanks!

@tjstum tjstum merged commit c7d9707 into python-trio:master Sep 24, 2024
8 of 9 checks passed
@trio-bot
Copy link

trio-bot bot commented Sep 24, 2024

Hey @Hnasar, it looks like that was the first time we merged one of your PRs! Thanks so much! 🎉 🎂

If you want to keep contributing, we'd love to have you. So, I just sent you an invitation to join the python-trio organization on Github! If you accept, then here's what will happen:

  • Github will automatically subscribe you to notifications on all our repositories. (But you can unsubscribe again if you don't want the spam.)

  • You'll be able to help us manage issues (add labels, close them, etc.)

  • You'll be able to review and merge other people's pull requests

  • You'll get a [member] badge next to your name when participating in the Trio repos, and you'll have the option of adding your name to our member's page and putting our icon on your Github profile (details)

If you want to read more, here's the relevant section in our contributing guide.

Alternatively, you're free to decline or ignore the invitation. You'll still be able to contribute as much or as little as you like, and I won't hassle you about joining again. But if you ever change your mind, just let us know and we'll send another invitation. We'd love to have you, but more importantly we want you to do whatever's best for you.

If you have any questions, well... I am just a humble Python script, so I probably can't help. But please do post a comment here, or in our chat, or on our forum, whatever's easiest, and someone will help you out!

@Hnasar Hnasar deleted the patch-1 branch September 24, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants