Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix wrong statement about sys.modules with importlib import mode #12985

Merged
merged 1 commit into from
Nov 25, 2024
Merged

docs: Fix wrong statement about sys.modules with importlib import mode #12985

merged 1 commit into from
Nov 25, 2024

Conversation

The-Compiler
Copy link
Member

Follow-up to #7870, see #12983.

cc @tadeu

@The-Compiler The-Compiler added backport 8.3.x apply to PRs at any point; backports the changes to the 8.3.x branch type: docs documentation improvement, missing or needing clarification skip news used on prs to opt out of the changelog requirement labels Nov 23, 2024
nicoddemus
nicoddemus approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @The-Compiler!

@nicoddemus nicoddemus merged commit 2157caf into pytest-dev:main Nov 25, 2024
29 checks passed
@patchback Patchback
Copy link

patchback bot commented Nov 25, 2024 •
edited
Loading

Backport to 8.3.x: 💚 backport PR created

✅ Backport PR branch: patchback/backports/8.3.x/2157caf87960d904c8547c9168c94a7d535f21e0/pr-12985

Backported as #12991

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 25, 2024
@The-Compiler @patchback
docs: Fix wrong statement about sys.modules with importlib import mode (
a2577bf 
#12985)

Follow-up to #7870, see #12983.

(cherry picked from commit 2157caf)
@patchback patchback bot mentioned this pull request Nov 25, 2024
Merged
nicoddemus pushed a commit that referenced this pull request Nov 25, 2024
@patchback @The-Compiler
docs: Fix wrong statement about sys.modules with importlib import mode (
b541721 
#12985) (#12991)

Follow-up to #7870, see #12983.

(cherry picked from commit 2157caf)

Co-authored-by: Florian Bruhin <me@the-compiler.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
backport 8.3.x apply to PRs at any point; backports the changes to the 8.3.x branch skip news used on prs to opt out of the changelog requirement type: docs documentation improvement, missing or needing clarification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@The-Compiler @nicoddemus