Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template update #129

Merged
merged 25 commits into from
Oct 23, 2023
Merged

Template update #129

merged 25 commits into from
Oct 23, 2023

Conversation

aburrell
Copy link
Member

@aburrell aburrell commented Oct 19, 2023

Description

Addresses #113

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Installed locally

Test Configuration

  • Operating system: OS X Big Sur
  • Version number: Python 3.9
  • Any details about your local setup that are relevant

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes

If this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release

Fixed formatting and grammar in the issue templates.
Fixed formatting in the PR template.
Updated the CI tests to use pyproject.toml.
Updated the .gitignore comments.
Added the required configuration file for RTD.
Added FAQ section to the code of conduct.
Updated the style, links, and wording in the contributing guidelines.
Updated the document configuration file.
Update the manifest to reflect the package changes.
Replaced the setup.py with the new standard, a pyproject.toml file.
Get the version data from the pyproject.toml.
Remove unnecessary text file.
Cycled pysat minimum version, removed alpha note for the next release and fixed bug in the example.
Removed data from setup.cfg that is now stored in the pyproject.toml.
Update the package limits in the test requirements.
Added a summary of changes to the log.
Updated the installation instructions to use the pyproject.toml file.
@aburrell aburrell mentioned this pull request Oct 19, 2023
10 tasks
Added missing key to install dependencies.
Ensured there is always a space after a keyword.
Replace placeholder with real package name.
Re-added a variable that was accidentally removed.
Import name is different from the package name.
Fixed resource usage by specifying full path with os.path.join.
Fixed the path call to use the resource library correctly.
Added a missing requirement for the operational install.
@aburrell
Copy link
Member Author

Woohoo! All tests failing as expected. This is needed to merge before the fix for the log test.

@aburrell aburrell added this to the 0.1.0 Release milestone Oct 19, 2023
@aburrell aburrell linked an issue Oct 19, 2023 that may be closed by this pull request
2 tasks
Copy link
Member

@jklenzing jklenzing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. There's an inconsistency about the "alpha" status between the readme and pyproject. That may be intentional and changed in the RC. The only test failure is expected, and a fix is in the queue.

{name = "Angeline Burrell", email = "pysat.developers@gmail.com"}
]
classifiers = [
"Development Status :: 3 - Alpha",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still Alpha?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eh, I made some RC changes throughout. The next release will go from alpha to beta and I jumped the gun a little bit.

@aburrell aburrell merged commit 0d33b54 into develop Oct 23, 2023
3 of 19 checks passed
@aburrell aburrell mentioned this pull request Oct 23, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check standard docs for pysatSpaceWeather
2 participants