-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template update #129
Template update #129
Conversation
Fixed formatting and grammar in the issue templates.
Fixed formatting in the PR template.
Updated the CI tests to use pyproject.toml.
Updated the .gitignore comments.
Added the required configuration file for RTD.
Added FAQ section to the code of conduct.
Updated the style, links, and wording in the contributing guidelines.
Updated the document configuration file.
Update the manifest to reflect the package changes.
Replaced the setup.py with the new standard, a pyproject.toml file.
Get the version data from the pyproject.toml.
Remove unnecessary text file.
Cycled pysat minimum version, removed alpha note for the next release and fixed bug in the example.
Removed data from setup.cfg that is now stored in the pyproject.toml.
Update the package limits in the test requirements.
Added a summary of changes to the log.
Updated the installation instructions to use the pyproject.toml file.
Added missing key to install dependencies.
Ensured there is always a space after a keyword.
Replace placeholder with real package name.
Re-added a variable that was accidentally removed.
Import name is different from the package name.
Fixed resource usage by specifying full path with os.path.join.
Fixed the path call to use the resource library correctly.
Added a missing requirement for the operational install.
Woohoo! All tests failing as expected. This is needed to merge before the fix for the log test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. There's an inconsistency about the "alpha" status between the readme and pyproject. That may be intentional and changed in the RC. The only test failure is expected, and a fix is in the queue.
{name = "Angeline Burrell", email = "pysat.developers@gmail.com"} | ||
] | ||
classifiers = [ | ||
"Development Status :: 3 - Alpha", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still Alpha?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eh, I made some RC changes throughout. The next release will go from alpha to beta and I jumped the gun a little bit.
Description
Addresses #113
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Installed locally
Test Configuration
Checklist:
develop
(notmain
) branchCHANGELOG.md
, summarizing the changesIf this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release