-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release Candidate 0.3.0 #75
Conversation
Readthedocs is having trouble loading the autodoc info: https://pysatmissions.readthedocs.io/en/rc_0_3_0/supported_instruments.html |
Looks like there are some important warnings raised in the RTD log. For example:
More here: https://readthedocs.org/api/v2/build/16783478.txt |
Co-authored-by: Angeline Burrell <aburrell@users.noreply.github.com>
Co-Authored-By: Angeline Burrell <aburrell@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Local build and tests work on my end
BUG: readthedocs
@@ -1,10 +1,13 @@ | |||
# -*- coding: utf-8 -*- | |||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not the right place, closest I could get.
the methods area doesn't have an API in the docs, pysatMissions.methods.magcoords
and pysatMissions.methods.satellite
. Similarly, pysatMissions.instruments.methods.orbits
# | ||
# This file does only contain a selection of the most common options. For a | ||
# full list see the documentation: | ||
# https://www.sphinx-doc.org/en/master/config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not the right place.
In tutorials, you currently have
import pysat
from pysatMissions.methods import magcoord
inst = pysat.Instrument(platform='pysat', name='testing')
inst.custom_attach(magcoord.add_aacgm_coordinates,
kwargs={'glat_label': 'latitude',
'glong_label': 'longitude',
'alt_label': 'altitude'})
recommend using the existing sgp4
instrument defined above and switching to
import pysat
from pysatMissions.methods import magcoord
sgp4 = pysat.Instrument(inst_module=missions_sgp4, num_samples=3600)
sgp4.custom_attach(magcoord.add_aacgm_coordinates,
kwargs={'glat_label': 'latitude',
'glong_label': 'longitude',
'alt_label': 'geod_altitude'})
sgp4.load(2019, 1)
No warnings are raised about unable to perform conversion
and shows how to apply to the orbit simulator.
@rstoneback, I've updated the docs accordingly and added a date. If it looks good to you, I can finalize the release this afternoon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jklenzing!
Description
Alpha release fully compatible with pysat 3.0.0+.
Type of change
How Has This Been Tested?
This has been tested by running examples and unit tests locally
Test Configuration
Checklist:
CHANGELOG.md
, summarizing the changes