-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Update templates #95
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed typos in the issue templates.
Added new item for the PR checklist.
Updated the test yamls to use pyproject.toml and cycle the version support.
Added a readthedocs yaml.
Added missing section to the code of conduct.
Fixed format and updated style requirements in the contributing guidelines.
Replaced the setup.py with pyproject.toml.
Fixed broken links and updated dependencies in the README.
Updated the version support to use pyproject.toml.
Added a summary of the changes to the changelog.
Fixed matrix variables so that new if statement is triggered.
Updated version access in conf.py.
Removed duplicate explicit links.
Included a missing example in the example index.
Removed comma from authors.
Update the installation guide to reflect the change to pyproject.toml.
2 tasks
10 tasks
Decrease in coverage due to a reduction in lines in the top-level |
Removed the old version.txt file from the manifest.
jklenzing
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Failing tests a result of the download failure issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #78 by updating tests, documents, and adding a pyproject.toml.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Built docs locally.
Test Configuration
Checklist:
develop
(notmain
) branchCHANGELOG.md
, summarizing the changesIf this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release