Replace scan in BetaGeoBetaBinom #707
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add scaling into lift test method * test scaling methods * test change of MMM likelihood * link up beta_channel parameters * change name to sigma * reorganize and edit * closes #406 * address the feedback in docstrings * add more to docstring * format the docstring * be verbose for future devs * be explicit for the column max values * incorporate the feedback * hide cells and add to intro * add conclusion * switch to header 2 * run notebook through * move the types together * separate model estimated from empirical * fix typos
* drop python 3.9 * try python 3.12 * undo try python 3.12
* improve nb * rm warnings and add link to lifetimes quickstart * address comments * feedback part 3 * remove warnings manually
* add more info to the notebook * hide plots code * fix plot y labels * fix plot outputs and remove model build * improve final note probability plots * address comments * use quickstart dataset * feedback part 3 * remowe warnings manually * feedback part 4
* improve mmm docs init * add more code examples to docstrings * minor improvemeents * typo * better phrasing * add thomas suggestion
remove ruff E501 ignore
updates: - [github.com/astral-sh/ruff-pre-commit: v0.3.5 → v0.3.7](astral-sh/ruff-pre-commit@v0.3.5...v0.3.7) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Juan Orduz <juanitorduz@gmail.com>
* fix potential bugs * minor improvements * remove rule for nb * fix test * improve tests syntax * use stacklevel 2 for warnings * use stacklevel 1 for warnings as they are used in public methods * ignore B904 * undo change * ricardos feedback * use fit_posterior * Update pymc_marketing/clv/models/gamma_gamma.py Co-authored-by: Ricardo Vieira <28983449+ricardoV94@users.noreply.github.com> * last fix XD --------- Co-authored-by: Ricardo Vieira <28983449+ricardoV94@users.noreply.github.com>
* notebook opening and imports * model definition markdown * Data Load Notebook section * WIP model fitting section * added notebook to docs directory * notebook edits and graph code * ppc section and nb cleanup * demz sampling and WIP plotting * WIP predictive plots * WIP heatmap plots * predictive plots * WIP covariates and nbqa-ruff edits * covariate section * plot additions * fig sizes * remove model file
…book (#651) * add spaces, increase indentation, and fix number order * explicit with 6
* Creating plot waterfall Co-Authored-By: Carlos Trujillo <59846724+cetagostini@users.noreply.github.com> * requested changes * pre-commit --------- Co-authored-by: Carlos Trujillo <59846724+cetagostini@users.noreply.github.com>
Databricks should have a lower-case b.
updates: - [github.com/astral-sh/ruff-pre-commit: v0.4.1 → v0.4.2](astral-sh/ruff-pre-commit@v0.4.1...v0.4.2) - [github.com/pre-commit/mirrors-mypy: v1.9.0 → v1.10.0](pre-commit/mirrors-mypy@v1.9.0...v1.10.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* support for negative values and dates (if used) * fix terrible spelling * test dates in coords * cover numpy objects * consolidate the tests
updates: - [github.com/astral-sh/ruff-pre-commit: v0.4.8 → v0.4.9](astral-sh/ruff-pre-commit@v0.4.8...v0.4.9) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* initial notebook * add to example * push up some feedback * change the number of channels * updates * final message * add more feedback * remove since wasnt working the way I wanted
* start addressing sphinx warnings and rendering issues * forgot formatting comment * Add numpydoc as dependency * fix dataset type --------- Co-authored-by: Juan Orduz <juanitorduz@gmail.com>
* Allowing non center parametrization * update notebook * Adding example in docstring * change * Push code changes. * A painful and ugly change! The things one does for democracy! * Missing parts! * adding missing test 2D * Missing raise --------- Co-authored-by: Will Dean <57733339+wd60622@users.noreply.github.com>
* fix typing * empty * empty * empty * dummy * undo dummy * empty
* remove noqa * fix escape * empty * empty
updates: - [github.com/astral-sh/ruff-pre-commit: v0.4.9 → v0.4.10](astral-sh/ruff-pre-commit@v0.4.9...v0.4.10) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* utils.customer_lifetime_value * expected_customer_lifetime_value * WIP clv.models.gamma_gamma.py * gamma_gamma API * fixed circular import * gamma_gamma tests * delete tests/datasets/test_summary.csv * clv test_utils.py * remove expected_purchases(future_t=0) * remove monetary_value arg * WIP docstrings * notebooks * docstrings * Revert "notebooks" This reverts commit a3154d9. * gamma-gamma notebook * docstrings
* quickstart * pareto_nbd fit warning * pareto_nbd docstrings * clv.utils docstrings * gamma_gamma docstrings * beta_geo docstrings * CLV sections in README and index
* run notebooks init * change kernel name * change kernel name * change kernel name * rm docs * add nb * fix nb * fig dpi * update model object * no output * test mmm notebooks * fix path * graphviz * sudo * paralelize and Path * reqs * undo * comments * try budget allocation * add quickstart * ignore budget allocation * add make command * use make
* Time Varaying notebook * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * requested changes * quick change * Adding to index md * remove change mmm_budget_allocation_example.ipynb * quick correction * Small changes * Small title change --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Will Dean <57733339+wd60622@users.noreply.github.com>
* reimplement hierarchical parameters with wrapper class * write tests for prior class * explicit with dependencies * missing test dependency * raise KeyError early and test dims * add prior module to docs * support for media transformations * add some documentation * migrate the delayed_saturated model to Prior class * migrate the delayed_saturated model to Prior class * add an example image * add the example image * push up some more documentation * support for student-t * add configuration notebook * catch all the errrors * add more to notebook * use a sigma which has transform * add parsing error catches * add watermark * test the parsing warnings and error handling * have a default to dict * default handles Prior class * passing plotting tests * support for lift tests * fix two failing tests * update notebook * change order of pre-commit back * migrate to Prior and parse_model_config * migrate the clv tests * test for warning * run pre-commit on all files * switch to Prior in components * test for the components * remove the previous dictionary function * migrate to Prior class in mmm * remove the unused key,value * migrate to Prior class in clv tests * back to dict for warning test * isort and work out example indentation * change the example name * use juans suggestions * change graph to to_graph * rerun the time varying media * rerun the clv notebooks I could get to work
updates: - [github.com/astral-sh/ruff-pre-commit: v0.4.10 → v0.5.0](astral-sh/ruff-pre-commit@v0.4.10...v0.5.0) - [github.com/pre-commit/mirrors-mypy: v1.10.0 → v1.10.1](pre-commit/mirrors-mypy@v1.10.0...v1.10.1) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
ulfaslak
force-pushed
the
main
branch
4 times, most recently
from
f9a38fd
to
818ba39
Compare
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #703
📚 Documentation preview 📚: https://pymc-marketing--707.org.readthedocs.build/en/707/